Sign upLogin

sensu-plugins/sensu-plugins-haproxy

View on GitHub
Star

Showing 11 of 21 total issues

Method run has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  def run #rubocop:disable all
    if config[:service] || config[:all_services]
      services = acquire_services
    else
      unknown 'No service specified'
Severity: Minor
Found in bin/check-haproxy.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    out = nil
    1.upto(config[:retries]) do |_i|
      out = acquire_stats
      break unless out.to_s.length.zero?
Severity: Minor
Found in bin/metrics-haproxy.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method acquire_services has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def acquire_services #rubocop:disable all
    uri = URI.parse(config[:stats_source])

    if uri.is_a?(URI::Generic) && File.socket?(uri.path)
      srv = UNIXSocket.open(config[:stats_source])
Severity: Minor
Found in bin/check-haproxy.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run #rubocop:disable all
    if config[:service] || config[:all_services]
      services = acquire_services
    else
      unknown 'No service specified'
Severity: Major
Found in bin/check-haproxy.rb - About 2 hrs to fix

    File metrics-haproxy.rb has 257 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'sensu-plugin/metric/cli'
require 'net/http'
require 'net/https'
require 'socket'
require 'csv'
    Severity: Minor
    Found in bin/metrics-haproxy.rb - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

          if services.empty?
      message "No services matching /#{config[:service]}/"
      if config[:missing_fail]
        critical
      elsif config[:missing_ok]
      Severity: Critical
      Found in bin/check-haproxy.rb - About 1 hr to fix

        Method run has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def run
    out = nil
    1.upto(config[:retries]) do |_i|
      out = acquire_stats
      break unless out.to_s.length.zero?
        Severity: Minor
        Found in bin/metrics-haproxy.rb - About 1 hr to fix

          Method acquire_services has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def acquire_services #rubocop:disable all
    uri = URI.parse(config[:stats_source])

    if uri.is_a?(URI::Generic) && File.socket?(uri.path)
      srv = UNIXSocket.open(config[:stats_source])
          Severity: Minor
          Found in bin/check-haproxy.rb - About 1 hr to fix

            Method render_output has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

              def render_output(type, pxname, svname, index, value)
    return if value.nil?

    field_index = config[:use_haproxy_names] ? 0 : 1
    field_name = CSV_FIELDS[index][field_index]
            Severity: Minor
            Found in bin/metrics-haproxy.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method acquire_stats has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              def acquire_stats
    uri = URI.parse(config[:connection])

    if uri.is_a?(URI::Generic) && File.socket?(uri.path)
      socket = UNIXSocket.new(config[:connection])
            Severity: Minor
            Found in bin/metrics-haproxy.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method render_output has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              def render_output(type, pxname, svname, index, value)
            Severity: Minor
            Found in bin/metrics-haproxy.rb - About 35 mins to fix
              Severity
              Category
              Status
              Source
              Language