Sign upLogin

sensu-plugins/sensu-plugins-io-checks

View on GitHub
Star

Showing 4 of 4 total issues

Method parse_results has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def parse_results(raw)
    stats = {}
    key = nil
    headers = nil
    stage = :initial
Severity: Minor
Found in bin/metrics-iostat-extended.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_results has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def parse_results(raw)
    stats = {}
    key = nil
    headers = nil
    stage = :initial
Severity: Minor
Found in bin/metrics-iostat-extended.rb - About 1 hr to fix

    Method parse_0_8 has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def parse_0_8(str)
    value = /(#{NUMBER}) (#{TIME_UNIT})\s/
    sep = /\/\s/
    pattern = /^#{STATS_HEADER} = #{value}#{sep}#{value}#{sep}#{value}#{sep}#{value}$/
    str.scan(pattern).each do |scanned|
    Severity: Minor
    Found in bin/metrics-ioping.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def run
    cmd = 'iostat'
    args = ['-x', config[:interval].to_s, '2']
    args.push('-N') if config[:mappernames]
    args.push(File.basename(config[:disk])) if config[:disk]
    Severity: Minor
    Found in bin/metrics-iostat-extended.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language