Sign upLogin

sensu-plugins/sensu-plugins-logstash

View on GitHub
Star

Showing 6 of 10 total issues

Method run has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

  def run # rubocop:disable Metrics/AbcSize
    stats = get_logstash_resource('/_node/stats')

    timestamp = Time.now.to_i
    node = stats
Severity: Minor
Found in bin/metrics-logstash-node.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run # rubocop:disable Metrics/AbcSize
    stats = get_logstash_resource('/_node/stats')

    timestamp = Time.now.to_i
    node = stats
Severity: Major
Found in bin/metrics-logstash-node.rb - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

        elsif node.key?('pipelines')
      node['pipelines'].each_key do |pipeline|
        if node['pipelines'][pipeline]['events'].nil? || node['pipelines'][pipeline]['events'] == 'null'
          # Skip
        else
    Severity: Critical
    Found in bin/metrics-logstash-node.rb - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

          if node.key?('pipeline')
      node['pipeline']['events'].each do |key, value|
        metrics["pipeline.events.#{key}"] = value
      end
      Severity: Critical
      Found in bin/metrics-logstash-node.rb - About 1 hr to fix

        Method handle has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def handle
    time = Time.now.utc.iso8601
    logstash_msg = {
      :@timestamp    => time,
      :@version      => 1,
        Severity: Minor
        Found in bin/handler-logstash.rb - About 1 hr to fix

          Method get_logstash_resource has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def get_logstash_resource(resource)
    headers = {}
    if config[:user] && config[:password]
      auth = 'Basic ' + Base64.encode64("#{config[:user]}:#{config[:password]}").chomp
      headers = { 'Authorization' => auth }
          Severity: Minor
          Found in bin/metrics-logstash-node.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language