sensu-plugins/sensu-plugins-mysql

View on GitHub

Showing 36 of 66 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      'commands' => {
        'Com_admin_commands' => 'admin_commands',
        'Com_begin' => 'begin',
        'Com_change_db' => 'change_db',
        'Com_commit' => 'commit',
Severity: Major
Found in bin/metrics-mysql-graphite.rb and 1 other location - About 1 hr to fix
bin/metrics-mysql-raw.rb on lines 197..230

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      'commands' => {
        'Com_admin_commands' => 'admin_commands',
        'Com_begin' => 'begin',
        'Com_change_db' => 'change_db',
        'Com_commit' => 'commit',
Severity: Major
Found in bin/metrics-mysql-raw.rb and 1 other location - About 1 hr to fix
bin/metrics-mysql-graphite.rb on lines 129..162

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      'general' => {
        'Bytes_received' => 'rxBytes',
        'Bytes_sent' => 'txBytes',
        'Key_read_requests' => 'keyRead_requests',
        'Key_reads' => 'keyReads',
Severity: Minor
Found in bin/metrics-mysql-graphite.rb and 1 other location - About 1 hr to fix
bin/metrics-mysql-raw.rb on lines 164..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    stdout, _stderr, status = Open3.capture3(cmd)
    puts status.to_s.split(' ')[3] if config[:verbose]
    if status == 0
      puts status.to_s if config[:verbose]
      stdout.split("\n").each do |row|
Severity: Minor
Found in bin/metrics-mysql-raw.rb and 1 other location - About 1 hr to fix
bin/metrics-mysql-raw.rb on lines 350..359

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

--port #{config[:port]} --socket #{db_socket} -p\"#{db_pass.chomp}\" --batch \
--disable-column-names -e 'SHOW GLOBAL STATUS;'"
        stdout, _stderr, status = Open3.capture3(cmd)
        puts status.to_s.split(' ')[3] if config[:verbose]
        if status == 0
Severity: Minor
Found in bin/metrics-mysql-raw.rb and 1 other location - About 1 hr to fix
bin/metrics-mysql-raw.rb on lines 315..324

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      'general' => {
        'Bytes_received' => 'rxBytes',
        'Bytes_sent' => 'txBytes',
        'Key_read_requests' => 'keyRead_requests',
        'Key_reads' => 'keyReads',
Severity: Minor
Found in bin/metrics-mysql-raw.rb and 1 other location - About 1 hr to fix
bin/metrics-mysql-graphite.rb on lines 97..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      'innodb' => {
        'Innodb_buffer_pool_pages_total' => 'bufferTotal_pages',
        'Innodb_buffer_pool_pages_free' => 'bufferFree_pages',
        'Innodb_buffer_pool_pages_dirty' => 'bufferDirty_pages',
        'Innodb_buffer_pool_pages_data' => 'bufferUsed_pages',
Severity: Minor
Found in bin/metrics-mysql-raw.rb and 1 other location - About 45 mins to fix
bin/metrics-mysql-graphite.rb on lines 179..198

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      'innodb' => {
        'Innodb_buffer_pool_pages_total' => 'bufferTotal_pages',
        'Innodb_buffer_pool_pages_free' => 'bufferFree_pages',
        'Innodb_buffer_pool_pages_dirty' => 'bufferDirty_pages',
        'Innodb_buffer_pool_pages_data' => 'bufferUsed_pages',
Severity: Minor
Found in bin/metrics-mysql-graphite.rb and 1 other location - About 45 mins to fix
bin/metrics-mysql-raw.rb on lines 247..266

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        slave_results.fetch_hash.each_pair do |key, value|
          if metrics['general'].include?(key)
            # Replication lag being null is bad, very bad, so negativate it here
            value = -1 if key == 'Seconds_Behind_Master' && value.nil?
            output "#{config[:scheme]}.#{mysql_shorthostname}.general.#{metrics['general'][key]}", value
Severity: Minor
Found in bin/metrics-mysql-graphite.rb and 1 other location - About 40 mins to fix
bin/metrics-mysql-raw.rb on lines 297..301

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    slave_results.first.each do |key, value|
      if metrics['general'].include?(key)
        # Replication lag being null is bad, very bad, so negativate it here
        value = -1 if key == 'Seconds_Behind_Master' && value.nil?
        output "#{config[:scheme]}.#{mysql_shorthostname}.general.#{metrics['general'][key]}", value
Severity: Minor
Found in bin/metrics-mysql-raw.rb and 1 other location - About 40 mins to fix
bin/metrics-mysql-graphite.rb on lines 244..248

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
      db_pass = section['password']
Severity: Major
Found in bin/check-mysql-query-result-count.rb and 12 other locations - About 35 mins to fix
bin/check-mysql-alive.rb on lines 84..91
bin/check-mysql-connections.rb on lines 77..84
bin/check-mysql-disk.rb on lines 80..87
bin/check-mysql-innodb-lock.rb on lines 71..78
bin/check-mysql-msr-replication-status.rb on lines 90..97
bin/check-mysql-replication-status.rb on lines 117..124
bin/check-mysql-threads.rb on lines 103..110
bin/metrics-mysql-graphite.rb on lines 215..222
bin/metrics-mysql-multiple-select-count.rb on lines 79..86
bin/metrics-mysql-processes.rb on lines 108..115
bin/metrics-mysql-query-result-count.rb on lines 77..84
bin/metrics-mysql-select-count.rb on lines 77..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
      db_pass = section['password']
Severity: Major
Found in bin/metrics-mysql-select-count.rb and 12 other locations - About 35 mins to fix
bin/check-mysql-alive.rb on lines 84..91
bin/check-mysql-connections.rb on lines 77..84
bin/check-mysql-disk.rb on lines 80..87
bin/check-mysql-innodb-lock.rb on lines 71..78
bin/check-mysql-msr-replication-status.rb on lines 90..97
bin/check-mysql-query-result-count.rb on lines 85..92
bin/check-mysql-replication-status.rb on lines 117..124
bin/check-mysql-threads.rb on lines 103..110
bin/metrics-mysql-graphite.rb on lines 215..222
bin/metrics-mysql-multiple-select-count.rb on lines 79..86
bin/metrics-mysql-processes.rb on lines 108..115
bin/metrics-mysql-query-result-count.rb on lines 77..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
      db_pass = section['password']
Severity: Major
Found in bin/check-mysql-msr-replication-status.rb and 12 other locations - About 35 mins to fix
bin/check-mysql-alive.rb on lines 84..91
bin/check-mysql-connections.rb on lines 77..84
bin/check-mysql-disk.rb on lines 80..87
bin/check-mysql-innodb-lock.rb on lines 71..78
bin/check-mysql-query-result-count.rb on lines 85..92
bin/check-mysql-replication-status.rb on lines 117..124
bin/check-mysql-threads.rb on lines 103..110
bin/metrics-mysql-graphite.rb on lines 215..222
bin/metrics-mysql-multiple-select-count.rb on lines 79..86
bin/metrics-mysql-processes.rb on lines 108..115
bin/metrics-mysql-query-result-count.rb on lines 77..84
bin/metrics-mysql-select-count.rb on lines 77..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
      db_pass = section['password']
Severity: Major
Found in bin/metrics-mysql-query-result-count.rb and 12 other locations - About 35 mins to fix
bin/check-mysql-alive.rb on lines 84..91
bin/check-mysql-connections.rb on lines 77..84
bin/check-mysql-disk.rb on lines 80..87
bin/check-mysql-innodb-lock.rb on lines 71..78
bin/check-mysql-msr-replication-status.rb on lines 90..97
bin/check-mysql-query-result-count.rb on lines 85..92
bin/check-mysql-replication-status.rb on lines 117..124
bin/check-mysql-threads.rb on lines 103..110
bin/metrics-mysql-graphite.rb on lines 215..222
bin/metrics-mysql-multiple-select-count.rb on lines 79..86
bin/metrics-mysql-processes.rb on lines 108..115
bin/metrics-mysql-select-count.rb on lines 77..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
      db_pass = section['password']
Severity: Major
Found in bin/check-mysql-connections.rb and 12 other locations - About 35 mins to fix
bin/check-mysql-alive.rb on lines 84..91
bin/check-mysql-disk.rb on lines 80..87
bin/check-mysql-innodb-lock.rb on lines 71..78
bin/check-mysql-msr-replication-status.rb on lines 90..97
bin/check-mysql-query-result-count.rb on lines 85..92
bin/check-mysql-replication-status.rb on lines 117..124
bin/check-mysql-threads.rb on lines 103..110
bin/metrics-mysql-graphite.rb on lines 215..222
bin/metrics-mysql-multiple-select-count.rb on lines 79..86
bin/metrics-mysql-processes.rb on lines 108..115
bin/metrics-mysql-query-result-count.rb on lines 77..84
bin/metrics-mysql-select-count.rb on lines 77..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
      db_pass = section['password']
Severity: Major
Found in bin/metrics-mysql-processes.rb and 12 other locations - About 35 mins to fix
bin/check-mysql-alive.rb on lines 84..91
bin/check-mysql-connections.rb on lines 77..84
bin/check-mysql-disk.rb on lines 80..87
bin/check-mysql-innodb-lock.rb on lines 71..78
bin/check-mysql-msr-replication-status.rb on lines 90..97
bin/check-mysql-query-result-count.rb on lines 85..92
bin/check-mysql-replication-status.rb on lines 117..124
bin/check-mysql-threads.rb on lines 103..110
bin/metrics-mysql-graphite.rb on lines 215..222
bin/metrics-mysql-multiple-select-count.rb on lines 79..86
bin/metrics-mysql-query-result-count.rb on lines 77..84
bin/metrics-mysql-select-count.rb on lines 77..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
      db_pass = section['password']
Severity: Major
Found in bin/check-mysql-innodb-lock.rb and 12 other locations - About 35 mins to fix
bin/check-mysql-alive.rb on lines 84..91
bin/check-mysql-connections.rb on lines 77..84
bin/check-mysql-disk.rb on lines 80..87
bin/check-mysql-msr-replication-status.rb on lines 90..97
bin/check-mysql-query-result-count.rb on lines 85..92
bin/check-mysql-replication-status.rb on lines 117..124
bin/check-mysql-threads.rb on lines 103..110
bin/metrics-mysql-graphite.rb on lines 215..222
bin/metrics-mysql-multiple-select-count.rb on lines 79..86
bin/metrics-mysql-processes.rb on lines 108..115
bin/metrics-mysql-query-result-count.rb on lines 77..84
bin/metrics-mysql-select-count.rb on lines 77..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
      db_pass = section['password']
Severity: Major
Found in bin/metrics-mysql-multiple-select-count.rb and 12 other locations - About 35 mins to fix
bin/check-mysql-alive.rb on lines 84..91
bin/check-mysql-connections.rb on lines 77..84
bin/check-mysql-disk.rb on lines 80..87
bin/check-mysql-innodb-lock.rb on lines 71..78
bin/check-mysql-msr-replication-status.rb on lines 90..97
bin/check-mysql-query-result-count.rb on lines 85..92
bin/check-mysql-replication-status.rb on lines 117..124
bin/check-mysql-threads.rb on lines 103..110
bin/metrics-mysql-graphite.rb on lines 215..222
bin/metrics-mysql-processes.rb on lines 108..115
bin/metrics-mysql-query-result-count.rb on lines 77..84
bin/metrics-mysql-select-count.rb on lines 77..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
      db_pass = section['password']
Severity: Major
Found in bin/check-mysql-disk.rb and 12 other locations - About 35 mins to fix
bin/check-mysql-alive.rb on lines 84..91
bin/check-mysql-connections.rb on lines 77..84
bin/check-mysql-innodb-lock.rb on lines 71..78
bin/check-mysql-msr-replication-status.rb on lines 90..97
bin/check-mysql-query-result-count.rb on lines 85..92
bin/check-mysql-replication-status.rb on lines 117..124
bin/check-mysql-threads.rb on lines 103..110
bin/metrics-mysql-graphite.rb on lines 215..222
bin/metrics-mysql-multiple-select-count.rb on lines 79..86
bin/metrics-mysql-processes.rb on lines 108..115
bin/metrics-mysql-query-result-count.rb on lines 77..84
bin/metrics-mysql-select-count.rb on lines 77..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
      db_pass = section['password']
Severity: Major
Found in bin/check-mysql-replication-status.rb and 12 other locations - About 35 mins to fix
bin/check-mysql-alive.rb on lines 84..91
bin/check-mysql-connections.rb on lines 77..84
bin/check-mysql-disk.rb on lines 80..87
bin/check-mysql-innodb-lock.rb on lines 71..78
bin/check-mysql-msr-replication-status.rb on lines 90..97
bin/check-mysql-query-result-count.rb on lines 85..92
bin/check-mysql-threads.rb on lines 103..110
bin/metrics-mysql-graphite.rb on lines 215..222
bin/metrics-mysql-multiple-select-count.rb on lines 79..86
bin/metrics-mysql-processes.rb on lines 108..115
bin/metrics-mysql-query-result-count.rb on lines 77..84
bin/metrics-mysql-select-count.rb on lines 77..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language