sensu-plugins/sensu-plugins-nginx

View on GitHub

Showing 5 of 9 total issues

Method run has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    found = false
    attempts = 0
    until found || attempts >= 10
      attempts += 1
Severity: Minor
Found in bin/metrics-nginx.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method statutor has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  def statutor
    found = false
    attempts = 0
    begin
      until found || attempts >= 10
Severity: Minor
Found in bin/check-nginx-status.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    found = false
    attempts = 0
    until found || attempts >= 10
      attempts += 1
Severity: Minor
Found in bin/metrics-nginx.rb - About 2 hrs to fix

    Method run has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def run
        code = statutor
        #### Metrics
        code.body.split(/\r?\n/).each do |line|
          if line =~ /^Active connections:\s+(\d+)/
    Severity: Minor
    Found in bin/check-nginx-status.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method statutor has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def statutor
        found = false
        attempts = 0
        begin
          until found || attempts >= 10
    Severity: Minor
    Found in bin/check-nginx-status.rb - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language