Sign upLogin

sentilo/sentilo

View on GitHub
Star
sentilo-catalog-web/src/main/webapp/static/js/infobox.js

Summary

Maintainability
D
1 day
Test Coverage

File infobox.js has 276 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * @name InfoBox
 * @version 1.0 [January 11, 2010]
 * @author Gary Little (inspired by proof-of-concept code from Pamela Fox of Google)
 * @copyright Copyright 2010 Gary Little [gary at luxcentral.com]
Severity: Minor
Found in sentilo-catalog-web/src/main/webapp/static/js/infobox.js - About 2 hrs to fix

    Function setOptions has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    InfoBox.prototype.setOptions = function (opt_opts) {

  if (typeof opt_opts.boxStyle !== "undefined") { // Must be first

    this.boxStyle_ = opt_opts.boxStyle;
    Severity: Minor
    Found in sentilo-catalog-web/src/main/webapp/static/js/infobox.js - About 1 hr to fix

      Function setOptions has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      InfoBox.prototype.setOptions = function (opt_opts) {

  if (typeof opt_opts.boxStyle !== "undefined") { // Must be first

    this.boxStyle_ = opt_opts.boxStyle;
      Severity: Minor
      Found in sentilo-catalog-web/src/main/webapp/static/js/infobox.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function panBox_ has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      InfoBox.prototype.panBox_ = function (disablePan) {

  if (!disablePan) {

    var map = this.getMap();
      Severity: Minor
      Found in sentilo-catalog-web/src/main/webapp/static/js/infobox.js - About 1 hr to fix

        Function createInfoBoxDiv_ has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        InfoBox.prototype.createInfoBoxDiv_ = function () {

  var bw;

  if (!this.div_) {
        Severity: Minor
        Found in sentilo-catalog-web/src/main/webapp/static/js/infobox.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function panBox_ has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        InfoBox.prototype.panBox_ = function (disablePan) {

  if (!disablePan) {

    var map = this.getMap();
        Severity: Minor
        Found in sentilo-catalog-web/src/main/webapp/static/js/infobox.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createInfoBoxDiv_ has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        InfoBox.prototype.createInfoBoxDiv_ = function () {

  var bw;

  if (!this.div_) {
        Severity: Minor
        Found in sentilo-catalog-web/src/main/webapp/static/js/infobox.js - About 1 hr to fix

          Function getBoxWidths_ has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          InfoBox.prototype.getBoxWidths_ = function () {

  var computedStyle;
  var bw = {top: 0, bottom: 0, left: 0, right: 0};
  var box = this.div_;
          Severity: Minor
          Found in sentilo-catalog-web/src/main/webapp/static/js/infobox.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function setContent has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          InfoBox.prototype.setContent = function (content) {

  this.content_ = content;

  if (this.div_) {
          Severity: Minor
          Found in sentilo-catalog-web/src/main/webapp/static/js/infobox.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          InfoBox.prototype.show = function () {

  this.isHidden_ = false;
  this.div_.style.visibility = "visible";
};
          Severity: Minor
          Found in sentilo-catalog-web/src/main/webapp/static/js/infobox.js and 1 other location - About 55 mins to fix
          sentilo-catalog-web/src/main/webapp/static/js/infobox.js on lines 575..579

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          InfoBox.prototype.hide = function () {

  this.isHidden_ = true;
  this.div_.style.visibility = "hidden";
};
          Severity: Minor
          Found in sentilo-catalog-web/src/main/webapp/static/js/infobox.js and 1 other location - About 55 mins to fix
          sentilo-catalog-web/src/main/webapp/static/js/infobox.js on lines 566..570

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status