Sign upLogin

sentilo/sentilo

View on GitHub
Star
sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js

Summary

Maintainability
D
2 days
Test Coverage

Function rowAddNew has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

     function rowAddNew(tabId) {
         var $tab_en_edic = $("#" + tabId);  //Table to edit
         var $filas = $tab_en_edic.find('tbody tr');
         
         if ($filas.length==0) {
Severity: Minor
Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js - About 1 hr to fix

    Function iterateEditableFields has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

         function iterateEditableFields($cols, tarea) {
         var n = 0;
         $cols.each(function() {
             n++;
             if ($(this).attr('name')=='buttons') return;  //excluye columna de botones
    Severity: Minor
    Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function setTableEditable has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

         $.fn.setTableEditable = function (options) {
         var defaults = {
             buttonsColumn:'first',   // Default position of buttons column            
             columnsEd: null,         //Index to editable columns. If null all td editables. Ex.: "1,2,3,4,5"
             $addButton: null,        //Jquery object of "Add" button
    Severity: Minor
    Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

           function setEditMode(but) {
         $(but).parent().find('#bAcep').show();
         $(but).parent().find('#bCanc').show();
         $(but).parent().find('#bEdit').hide();
         $(but).parent().find('#bElim').hide();
      Severity: Major
      Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js and 1 other location - About 6 hrs to fix
      sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js on lines 99..106

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 162.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

           function setNormalMode(but) {
         $(but).parent().find('#bAcep').hide();
         $(but).parent().find('#bCanc').hide();
         $(but).parent().find('#bEdit').show();
         $(but).parent().find('#bElim').show();
      Severity: Major
      Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js and 1 other location - About 6 hrs to fix
      sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js on lines 108..115

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 162.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

           var saveColHtml = '<div class="btn-group pull-left">'+
'<button id="bEdit" type="button" class="btn btn-sm btn-default" style="display:none;" onclick="rowEdit(this);">' +
'<i class="icon-pencil"></i>'+
'</button>'+
'<button id="bElim" type="button" class="btn btn-sm btn-default" style="display:none;" onclick="rowElim(this);">' +
      Severity: Major
      Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js and 1 other location - About 1 hr to fix
      sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js on lines 12..25

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        var newColHtml = '<div class="btn-group pull-left">'+
'<button id="bEdit" type="button" class="btn btn-sm btn-default"  onclick="rowEdit(this);">' +
'<i class="icon-pencil"></i>'+
'</button>'+
'<button id="bElim" type="button" class="btn btn-sm btn-default"  onclick="rowElim(this);">' +
      Severity: Major
      Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js and 1 other location - About 1 hr to fix
      sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js on lines 27..40

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

               iterateEditableFields($cols, function($td) {  //itera por la columnas
           var cont = $td.find('input').val(); //lee contenido del input
           $td.html(cont);  //fija contenido y elimina controles
         });
      Severity: Major
      Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js and 1 other location - About 1 hr to fix
      sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js on lines 143..146

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

               iterateEditableFields($cols, function($td) {  //itera por la columnas
             var cont = $td.find('div').html(); //lee contenido del div
             $td.html(cont);  //fija contenido y elimina controles
         });
      Severity: Major
      Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js and 1 other location - About 1 hr to fix
      sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js on lines 129..132

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

               if(params.buttonsColumn == 'first'){
             this.find('thead tr').prepend('<th name="buttons" class="span2"></th>');  //encabezado vacío
             this.find('tbody tr').prepend(colEdicHtml);
         }else{
      Severity: Minor
      Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js and 1 other location - About 30 mins to fix
      sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js on lines 60..63

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

               }else{
             this.find('thead tr').append('<th name="buttons" class="span2"></th>');  //encabezado vacío
             this.find('tbody tr').append(colEdicHtml);
         }
      Severity: Minor
      Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js and 1 other location - About 30 mins to fix
      sentilo-catalog-web/src/main/webapp/static/js/sentilo/additional_info.js on lines 57..60

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status