sentilo/sentilo

View on GitHub
sentilo-catalog-web/src/main/webapp/static/js/sentilo/chartist.js

Summary

Maintainability
F
3 days
Test Coverage

File chartist.js has 294 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// Small devices width
var smallDevicesWidth = 767;
// Number of points to display
var pointsLength;
// Labels array
Severity: Minor
Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/chartist.js - About 3 hrs to fix

    Function printStatisticsChart has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function printStatisticsChart(inputData, anchor, chartOptions) {
        isBarChart = false;
        sensorUnit = undefined;
        var chartHeight = 300;
        var chartTopPadding = 30;
    Severity: Major
    Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/chartist.js - About 2 hrs to fix

      Function printNumericalChart has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function printNumericalChart(inputData, sensorType, unit, anchor, chartOptions) {
          isBarChart = false;
          sensorUnit = unit;
          var chartHeight = 300;
          var chartTopPadding = 30;
      Severity: Major
      Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/chartist.js - About 2 hrs to fix

        Function printBooleanChart has 61 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function printBooleanChart(inputData, anchor, chartOptions) {
            isBarChart = true;
            sensorUnit = undefined;
            var chartHeight = 300;
            var chartTopPadding = 30;
        Severity: Major
        Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/chartist.js - About 2 hrs to fix

          Function printNumericalChart has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

          function printNumericalChart(inputData, sensorType, unit, anchor, chartOptions) {
              isBarChart = false;
              sensorUnit = unit;
              var chartHeight = 300;
              var chartTopPadding = 30;
          Severity: Minor
          Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/chartist.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function printBooleanChart has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

          function printBooleanChart(inputData, anchor, chartOptions) {
              isBarChart = true;
              sensorUnit = undefined;
              var chartHeight = 300;
              var chartTopPadding = 30;
          Severity: Minor
          Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/chartist.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function printStatisticsChart has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

          function printStatisticsChart(inputData, anchor, chartOptions) {
              isBarChart = false;
              sensorUnit = undefined;
              var chartHeight = 300;
              var chartTopPadding = 30;
          Severity: Minor
          Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/chartist.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function printNumericalChart has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function printNumericalChart(inputData, sensorType, unit, anchor, chartOptions) {
          Severity: Minor
          Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/chartist.js - About 35 mins to fix

            Function labelInterpolationFunction has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            function labelInterpolationFunction(value, index){
                // Hide labels if number of points to display is greater than 15
                if(pointsLength < 15){
                    return value;
                }else if (pointsLength <40){
            Severity: Minor
            Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/chartist.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                if (chartOptions !== null && chartOptions !== undefined) {
                    if (chartOptions.height !== undefined) {
                        chartHeight = chartOptions.height;    
                    }
                    if (chartOptions.topPadding !== undefined) {
            sentilo-catalog-web/src/main/webapp/static/js/sentilo/chartist.js on lines 115..128
            sentilo-catalog-web/src/main/webapp/static/js/sentilo/chartist.js on lines 187..200

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 123.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                if (chartOptions !== null && chartOptions !== undefined) {
                    if (chartOptions.height !== undefined) {
                        chartHeight = chartOptions.height;    
                    }
                    if (chartOptions.topPadding !== undefined) {
            sentilo-catalog-web/src/main/webapp/static/js/sentilo/chartist.js on lines 26..39
            sentilo-catalog-web/src/main/webapp/static/js/sentilo/chartist.js on lines 115..128

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 123.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                if (chartOptions !== null && chartOptions !== undefined) {
                    if (chartOptions.height !== undefined) {
                        chartHeight = chartOptions.height;    
                    }
                    if (chartOptions.topPadding !== undefined) {
            sentilo-catalog-web/src/main/webapp/static/js/sentilo/chartist.js on lines 26..39
            sentilo-catalog-web/src/main/webapp/static/js/sentilo/chartist.js on lines 187..200

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 123.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status