Sign upLogin

sentilo/sentilo

View on GitHub
Star
sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js

Summary

Maintainability
F
4 days
Test Coverage

File metrics.js has 461 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Dashboard functions
 */

//config
Severity: Minor
Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js - About 7 hrs to fix

    Function buildSingleObjects has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var buildSingleObjects=function(obj, tabname, k){    
    Object.entries(obj).forEach(entry => {
        let key = entry[0];
        let value = entry[1];          
        if(typeof value == 'object'){
    Severity: Minor
    Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js - About 1 hr to fix

      Function buildSingleObjects has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      var buildSingleObjects=function(obj, tabname, k){    
    Object.entries(obj).forEach(entry => {
        let key = entry[0];
        let value = entry[1];          
        if(typeof value == 'object'){
      Severity: Minor
      Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function percent has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      var percent=function(obj){     
    var res;
    if(obj <= 0) return obj;    
    if(obj.hasOwnProperty('free') && obj.hasOwnProperty('total')){
        if(obj.free==0)return 0;
      Severity: Minor
      Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function buildCanvas has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var buildCanvas=function(host, artefact, metricname,time){
    var name = host +"-"+ artefact;  
    var element="";
    for(var chart in charts){  
         if($(jqEscape(name+"_chart_"+charts[chart])).length==0){
      Severity: Minor
      Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js - About 1 hr to fix

        Function buildElement has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        var buildElement=function(tabname,obj, property,parent,isReadableByte){
        Severity: Minor
        Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js - About 35 mins to fix

          Function buildSimpleObjects has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          var buildSimpleObjects=function(obj, tabname, key, showProgressBar){

    Object.entries(obj).forEach(entry => {
        let k = entry[0];
        let v = entry[1];
          Severity: Minor
          Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                  if(obj.used==0)return 0;
          Severity: Major
          Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    if(res<=0)return 0;
            Severity: Major
            Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return (Math.round(res))
              Severity: Major
              Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js - About 30 mins to fix

                Function buildCanvas has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                var buildCanvas=function(host, artefact, metricname,time){
    var name = host +"-"+ artefact;  
    var element="";
    for(var chart in charts){  
         if($(jqEscape(name+"_chart_"+charts[chart])).length==0){
                Severity: Minor
                Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                var getData = function() {
    
    for (var c in chartNames){ 
    var newTime=addTimeValue(chartNames[c]);
    if(newTime != window.chartNames[c].data.labels[window.chartNames[c].data.labels.length -1]){
                Severity: Minor
                Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    $.each(data.artifactsMetrics, function(index, element ) {            
        var name = element.name.split(":");
        var tabname= name[1] + "-" + name[2];
        var state=getStatus(element.timestamp,element.state);
        buildAbstractElement(name[1],name[2], element.timestamp, state ) ;
                Severity: Major
                Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js and 1 other location - About 6 hrs to fix
                sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js on lines 91..100

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 165.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    $.each(data.artifactsMetrics, function(index, element ) {                   
        var name = element.name.split(":");
        var tabname= name[1] + "-" + name[2];
        var state=getStatus(element.timestamp,element.state);
        buildAbstractElement(name[1],name[2], element.timestamp, state ) ;
                Severity: Major
                Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js and 1 other location - About 6 hrs to fix
                sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js on lines 60..68

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 165.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            if(key=='requests' && value.length == undefined){ 
                
                $(jqEscape(tabname+"content")+" ul").last().append(
                    buildAgroupper(tabname,key,key));
                Severity: Minor
                Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js and 1 other location - About 55 mins to fix
                sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js on lines 152..187

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 54.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            }else if(key=='process_memory'){
                
                $(jqEscape(tabname+"content")+" ul").last().append(
                    buildAgroupper(tabname,key,key));
                Severity: Minor
                Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js and 1 other location - About 55 mins to fix
                sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js on lines 135..187

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 54.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                    $(jqEscape(tabname+"content")+" ul").last().append(
                        buildAgroupper(tabname,key+"_"+k,key));
                Severity: Minor
                Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js and 1 other location - About 40 mins to fix
                sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js on lines 163..164

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                    $(jqEscape(tabname+"content")+" ul").last().append(
                        buildAgroupper(tabname,key +"_"+k,key));
                Severity: Minor
                Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js and 1 other location - About 40 mins to fix
                sentilo-catalog-web/src/main/webapp/static/js/sentilo/metrics.js on lines 146..147

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status