Sign upLogin

serge-web/serge-web

View on GitHub
Star
client/src/Components/jsonSchemaEditor/json-schema-editor/editor.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function updateSchema has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

SchemaEditor.prototype.updateSchema = function (schema) {
  this.destroy()

  // Add extra validation logic for integer Schemas that use the `range` format.
  // For integer Schemas that use the `range` format we require that minimum and maximum properties are set, too.
Severity: Major
Found in client/src/Components/jsonSchemaEditor/json-schema-editor/editor.js - About 2 hrs to fix

    Function updateSchema has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    SchemaEditor.prototype.updateSchema = function (schema) {
  this.destroy()

  // Add extra validation logic for integer Schemas that use the `range` format.
  // For integer Schemas that use the `range` format we require that minimum and maximum properties are set, too.
    Severity: Minor
    Found in client/src/Components/jsonSchemaEditor/json-schema-editor/editor.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function SchemaEditor has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function SchemaEditor (elementId) {
  Editor.call(this, elementId)

  // Check whether the node is a properties button for an object,
  // and not for the schema of an object named properties
    Severity: Minor
    Found in client/src/Components/jsonSchemaEditor/json-schema-editor/editor.js - About 1 hr to fix

      Function SchemaEditor has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export function SchemaEditor (elementId) {
  Editor.call(this, elementId)

  // Check whether the node is a properties button for an object,
  // and not for the schema of an object named properties
      Severity: Minor
      Found in client/src/Components/jsonSchemaEditor/json-schema-editor/editor.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status