Sign upLogin

serge-web/serge-web

View on GitHub
Star
client/static/leaflet/select/leaflet.select.js

Summary

Maintainability
D
1 day
Test Coverage

File leaflet.select.js has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

L.Control.Select = L.Control.extend({
  options: {
    position: 'topright',

    iconMain: '≡',
Severity: Minor
Found in client/static/leaflet/select/leaflet.select.js - About 2 hrs to fix

    Function initialize has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      initialize(options) {
    this.menus = []
    L.Util.setOptions(this, options)
    const opts = this.options
    Severity: Major
    Found in client/static/leaflet/select/leaflet.select.js - About 2 hrs to fix

      Function _isSelected has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        _isSelected(item) {
    const sel = this.state.selected
    if (sel) {
      if (this._isGroup(item)) {
        if ('children' in item) {
      Severity: Minor
      Found in client/static/leaflet/select/leaflet.select.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function initialize has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        initialize(options) {
    this.menus = []
    L.Util.setOptions(this, options)
    const opts = this.options
      Severity: Minor
      Found in client/static/leaflet/select/leaflet.select.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _emit has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _emit(action, data) {
    const newState = {}

    switch (action) {
      case 'ITEM_SELECT':
      Severity: Minor
      Found in client/static/leaflet/select/leaflet.select.js - About 1 hr to fix

        Function _renderItem has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _renderItem(item, menu) {
    const selected = this._isSelected(item)

    const p = L.DomUtil.create('div', 'leaflet-control-select-menu-line', menu)
    const pContent = L.DomUtil.create(
        Severity: Minor
        Found in client/static/leaflet/select/leaflet.select.js - About 1 hr to fix

          Function _emit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            _emit(action, data) {
    const newState = {}

    switch (action) {
      case 'ITEM_SELECT':
          Severity: Minor
          Found in client/static/leaflet/select/leaflet.select.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _setState has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            _setState(newState) {
    // events
    if (
      this.options.onSelect && newState.selected &&
      ((this.options.multi && newState.selected.length !== this.state.selected.length) || !this.options.multi)
          Severity: Minor
          Found in client/static/leaflet/select/leaflet.select.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            _renderRadioIcon(selected, contentDiv) {
    const radio = L.DomUtil.create('span', 'radio icon', contentDiv)

    radio.innerHTML = selected
      ? this.options.iconChecked
          Severity: Major
          Found in client/static/leaflet/select/leaflet.select.js and 1 other location - About 1 hr to fix
          client/static/leaflet/select/leaflet.select.js on lines 253..259

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 64.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            _renderGroupIcon(selected, contentDiv) {
    const group = L.DomUtil.create('span', 'group icon', contentDiv)

    group.innerHTML = selected
      ? this.options.iconGroupChecked
          Severity: Major
          Found in client/static/leaflet/select/leaflet.select.js and 1 other location - About 1 hr to fix
          client/static/leaflet/select/leaflet.select.js on lines 245..251

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 64.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status