Sign upLogin

serp-spider/search-engine-google

View on GitHub
Star

Showing 35 of 47 total issues

Method getRelatedSearches has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getRelatedSearches()
    {
        $relatedSearches = [];
        if ($this->isMobile()) {
            $items = $this->cssQuery('#botstuff div:not(#bres) a.QsZ7bb');
Severity: Minor
Found in src/Page/GoogleSerp.php - About 1 hr to fix

    Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $host = 'www.google.com',
        $path = '/search',
        $scheme = 'https',
        array $query = [],
        $hash = '',
    Severity: Major
    Found in src/GoogleUrl.php - About 1 hr to fix

      Method build has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              $scheme = null,
        $host = null,
        $path = null,
        array $query = [],
        $hash = null,
      Severity: Major
      Found in src/GoogleUrl.php - About 1 hr to fix

        Method build has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                $scheme = null,
        $host = null,
        $path = null,
        array $query = [],
        $hash = null,
        Severity: Major
        Found in src/GoogleUrlArchive.php - About 1 hr to fix

          Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  $host = 'google.com',
        $path = '/search',
        $scheme = 'https',
        array $query = [],
        $hash = '',
          Severity: Major
          Found in src/GoogleUrlArchive.php - About 1 hr to fix

            Function parse has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function parse(GoogleDom $googleDOM, \DomElement $node, IndexedResultSet $resultSet)
    {
        $item = [
            'title' => function () use ($googleDOM, $node) {
                $aTag = $googleDOM->getXpath()->query('descendant::h3/a[2]', $node)->item(0);
            Severity: Minor
            Found in src/Parser/Evaluated/Rule/Adwords/AdwordsItem.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                    return new BaseResult(NaturalResultType::IMAGE_GROUP_IMAGE, $data);
            Severity: Major
            Found in src/Parser/Evaluated/Rule/Natural/ImageGroup.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return MediaFactory::createMediaFromSrc($img->getattribute('src'));
              Severity: Major
              Found in src/Parser/Evaluated/Rule/Natural/ImageGroupCarousel.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return MediaFactory::createMediaFromSrc($img->getAttribute('src'));
                Severity: Major
                Found in src/Parser/Evaluated/Rule/Natural/ImageGroup.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return null;
                  Severity: Major
                  Found in src/Parser/Evaluated/Rule/Natural/TweetsCarouselZ1m.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return $aTag->nodeValue;
                    Severity: Major
                    Found in src/Parser/Evaluated/Rule/Adwords/AdwordsItem.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return $aTag->nodeValue;
                      Severity: Major
                      Found in src/Parser/Evaluated/Rule/Adwords/AdwordsItem.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                            return null;
                        Severity: Major
                        Found in src/Parser/Evaluated/Rule/Adwords/AdwordsItem.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return new BaseResult(NaturalResultType::IMAGE_GROUP_IMAGE, $data);
                          Severity: Major
                          Found in src/Parser/Evaluated/Rule/Natural/ImageGroupCarousel.php - About 30 mins to fix

                            Function parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function parse(GoogleDom $dom, \DomElement $node, IndexedResultSet $resultSet)
    {
        $data = $this->parseNode($dom, $node);

        $resultTypes = [NaturalResultType::CLASSICAL];
                            Severity: Minor
                            Found in src/Parser/Evaluated/Rule/Natural/Classical/ClassicalResult.php - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language