Showing 40 of 76 total issues
Function movable has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def movable(self, from_x, from_y, to_x, to_y, promote):Avoid too many return statements within this function. Open
return (from_x, from_y, to_x, to_y, promote, koma)Avoid too many return statements within this function. Open
return FalseAvoid too many return statements within this function. Open
return FalseAvoid too many return statements within this function. Open
return FalseAvoid too many return statements within this function. Open
return FalseAvoid too many return statements within this function. Open
return FalseAvoid too many return statements within this function. Open
return FalseAvoid too many return statements within this function. Open
return FalseAvoid too many return statements within this function. Open
return FalseAvoid too many return statements within this function. Open
return TrueAvoid too many return statements within this function. Open
return FalseAvoid too many return statements within this function. Open
return FalseAvoid too many return statements within this function. Open
return TrueAvoid too many return statements within this function. Open
return FalseFunction move has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def move(self, from_x, from_y, to_x, to_y, promote):
koma = self.board[from_y][from_x]
koma_for_komadai = self.board[to_y][to_x]
if koma_for_komadai is not Koma.empty:
koma_for_komadai = koma_for_komadai.unpromote().go_enemy()- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function validate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def validate(self, shogi, user_id):
if shogi.first:
if not shogi.first_user.id == user_id:
return False
else:- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function move has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def move(movement_str, channel_id, user_id):
shogi = ShogiInput.manager.get_shogi(channel_id)
if not shogi.validate(shogi, user_id):
raise UserDifferentException()
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function drop has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def drop(self, koma, to_x, to_y):
if self.first:
self.first_tegoma.remove(koma)
else:
self.second_tegoma.remove(koma)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function find_koma has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def find_koma(self, koma):
koma_positions = []
for y in range(len(self.board)):
for x in range(len(self.board[y])):
if self.board[y][x] == koma:- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"