seyhunak/twitter-bootstrap-rails

View on GitHub
app/assets/javascripts/twitter/bootstrap/tab.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function activate has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  Tab.prototype.activate = function (element, container, callback) {
    var $active    = container.find('> .active')
    var transition = callback
      && $.support.transition
      && ($active.length && $active.hasClass('fade') || !!container.find('> .fade').length)
Severity: Minor
Found in app/assets/javascripts/twitter/bootstrap/tab.js - About 1 hr to fix

    Function show has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      Tab.prototype.show = function () {
        var $this    = this.element
        var $ul      = $this.closest('ul:not(.dropdown-menu)')
        var selector = $this.data('target')
    
    
    Severity: Minor
    Found in app/assets/javascripts/twitter/bootstrap/tab.js - About 1 hr to fix

      Function next has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function next() {
            $active
              .removeClass('active')
              .find('> .dropdown-menu > .active')
                .removeClass('active')
      Severity: Minor
      Found in app/assets/javascripts/twitter/bootstrap/tab.js - About 1 hr to fix

        Similar blocks of code found in 9 locations. Consider refactoring.
        Open

          $.fn.tab.noConflict = function () {
            $.fn.tab = old
            return this
          }
        Severity: Major
        Found in app/assets/javascripts/twitter/bootstrap/tab.js and 8 other locations - About 40 mins to fix
        app/assets/javascripts/twitter/bootstrap/affix.js on lines 139..142
        app/assets/javascripts/twitter/bootstrap/alert.js on lines 83..86
        app/assets/javascripts/twitter/bootstrap/button.js on lines 100..103
        app/assets/javascripts/twitter/bootstrap/carousel.js on lines 199..202
        app/assets/javascripts/twitter/bootstrap/collapse.js on lines 190..193
        app/assets/javascripts/twitter/bootstrap/dropdown.js on lines 149..152
        app/assets/javascripts/twitter/bootstrap/modal.js on lines 311..314
        app/assets/javascripts/twitter/bootstrap/scrollspy.js on lines 156..159

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            if (!selector) {
              selector = $this.attr('href')
              selector = selector && selector.replace(/.*(?=#[^\s]*$)/, '') // strip for ie7
            }
        Severity: Minor
        Found in app/assets/javascripts/twitter/bootstrap/tab.js and 1 other location - About 35 mins to fix
        app/assets/javascripts/twitter/bootstrap/alert.js on lines 29..32

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status