Sign upLogin

sgmap/boussole

View on GitHub
Star

Showing 2 of 276 total issues

Class TargetPublicDecorator has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

class TargetPublicDecorator < ApplicationDecorator
  def message(association)
    send("#{association}_message")
  end
Severity: Minor
Found in app/decorators/target_public_decorator.rb - About 2 hrs to fix

Method build_target_public has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def build_target_public
        @target_public ||= TargetPublicDecorator.(@service_offering.target_public)
        @target_public.build_working_age unless @target_public.working_age.try(:persisted?)
        @target_public.build_housing_age unless @target_public.housing_age.try(:persisted?)
        @target_public.build_resource unless @target_public.resource.try(:persisted?)
Severity: Minor
Found in app/controllers/agents/service_offerings/target_publics_controller.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language