sharetribe/sharetribe

View on GitHub
app/assets/javascripts/datepicker.js

Summary

Maintainability
C
1 day
Test Coverage

Function setupPerHour has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  var setupPerHour = function(options) {
    var dateInput = $('#start-on');
    var disabledDates = options.blocked_dates.map(function(d) {
      return new Date(d * 1000);
    });
Severity: Major
Found in app/assets/javascripts/datepicker.js - About 3 hrs to fix

    Function initializeFromToDatePicker has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      var initializeFromToDatePicker = function(rangeContainerId, opts) {
        opts = opts || {};
        var nightPicker = opts.nightPicker || false;
        var endDate = opts.endDate;
        var disabledStartDates = opts.disabledDates || [];
    Severity: Major
    Found in app/assets/javascripts/datepicker.js - About 2 hrs to fix

      Function setupPerDayOrNight has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        var setupPerDayOrNight = function(options) {
          var disabledDates = options.blocked_dates.map(function(d) {
            return new Date(d * 1000);
          });
          var quantityNight = options.listing_quantity_selector === 'night';
      Severity: Major
      Found in app/assets/javascripts/datepicker.js - About 2 hrs to fix

        Function setUpSelectOptions has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            var setUpSelectOptions = function(date, start, selectSelector) {
              var date_options = options.options_for_select[date],
                options_for_select = ['<option value="" disabled selected>' + selectOne + '</option>'],
                prevDisabled = false,
                blocked = '';
        Severity: Minor
        Found in app/assets/javascripts/datepicker.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                $("#start-on").focus(function() {
                  if(!$(this).is(":focus")) {
                    $("#start-on").datepicker("setDatesDisabled", disabledStartDates);
                  }
                });
          Severity: Major
          Found in app/assets/javascripts/datepicker.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/datepicker.js on lines 131..135

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                $("#end-on").focus(function() {
                  if(!$(this).is(":focus")) {
                    $("#end-on").datepicker("setDatesDisabled", disabledEndDates);
                  }
                });
          Severity: Major
          Found in app/assets/javascripts/datepicker.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/datepicker.js on lines 125..129

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status