Sign upLogin

sharetribe/sharetribe

View on GitHub
Star
client/app/components/sections/ListingWorkingHours/form.js

Summary

Maintainability
D
2 days
Test Coverage

File form.js has 390 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React, { Component } from 'react';
import PropTypes from 'prop-types';
import { Form, StyledSelect, FormField, Checkbox } from 'react-form';
import merge from 'lodash.merge';
import { t } from '../../../utils/i18n';
Severity: Minor
Found in client/app/components/sections/ListingWorkingHours/form.js - About 5 hrs to fix

    Function errorValidator has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

      errorValidator(values, field) {
    const currentDayIndex = field ? field[1] : null;
    const currentSlotIndex = field ? field[3] : null;
    const currentSlotProp = field ? field[4] : null;
    const currentSlot = field ? values.days[currentDayIndex].working_time_slots[currentSlotIndex] : null;
    Severity: Minor
    Found in client/app/components/sections/ListingWorkingHours/form.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function errorValidator has 98 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      errorValidator(values, field) {
    const currentDayIndex = field ? field[1] : null;
    const currentSlotIndex = field ? field[3] : null;
    const currentSlotProp = field ? field[4] : null;
    const currentSlot = field ? values.days[currentDayIndex].working_time_slots[currentSlotIndex] : null;
    Severity: Major
    Found in client/app/components/sections/ListingWorkingHours/form.js - About 3 hrs to fix

      Consider simplifying this complex logical expression.
      Open

                if (value &&
              ((prop === 'from' && otherFrom <= value && otherTill > value) ||
              (prop === 'till' && otherFrom < value && otherTill >= value))
            ) {
            intersection = true;
      Severity: Major
      Found in client/app/components/sections/ListingWorkingHours/form.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    <div className="timeSelect">
              <StyledSelect field={this.slotField.concat('till')}
                id={`${idPrefix}-till`} onChange={() => (this.handleChanges('till'))}
                options={this.timeSlotOptions('till')} placeholder={' '} />
            </div>
        Severity: Major
        Found in client/app/components/sections/ListingWorkingHours/form.js and 1 other location - About 3 hrs to fix
        client/app/components/sections/ListingWorkingHours/form.js on lines 91..95

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    <div className="timeSelect">
              <StyledSelect field={this.slotField.concat('from')}
                id={`${idPrefix}-from`} onChange={() => (this.handleChanges('from'))}
                options={this.timeSlotOptions('from')} placeholder={' '} />
            </div>
        Severity: Major
        Found in client/app/components/sections/ListingWorkingHours/form.js and 1 other location - About 3 hrs to fix
        client/app/components/sections/ListingWorkingHours/form.js on lines 99..103

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          constructor(props) {
    super(props);
    this.handleSubmit = this.handleSubmit.bind(this);
    this.errorValidator = this.errorValidator.bind(this);
    this.formApi = null;
        Severity: Major
        Found in client/app/components/sections/ListingWorkingHours/form.js and 1 other location - About 1 hr to fix
        client/app/components/composites/SideWinder/SideWinder.js on lines 82..87

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status