Sign upLogin

sharetribe/sharetribe

View on GitHub
Star
client/app/components/sections/Topbar/Topbar.js

Summary

Maintainability
D
2 days
Test Coverage

Function render has 154 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const { location, marketplace_color1: marketplaceColor1 } = { ...DEFAULT_CONTEXT, ...this.props.marketplace };
    const { loggedInUsername } = this.props.user || {};
    const isAdmin = !!(this.props.user && this.props.user.isAdmin && loggedInUsername);
Severity: Major
Found in client/app/components/sections/Topbar/Topbar.js - About 6 hrs to fix

    Function render has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

      render() {
    const { location, marketplace_color1: marketplaceColor1 } = { ...DEFAULT_CONTEXT, ...this.props.marketplace };
    const { loggedInUsername } = this.props.user || {};
    const isAdmin = !!(this.props.user && this.props.user.isAdmin && loggedInUsername);
    Severity: Minor
    Found in client/app/components/sections/Topbar/Topbar.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File Topbar.js has 302 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { Component } from 'react';
import PropTypes from 'prop-types';
import r, { div } from 'r-dom';
import classNames from 'classnames';
import * as placesUtils from '../../../utils/places';
    Severity: Minor
    Found in client/app/components/sections/Topbar/Topbar.js - About 3 hrs to fix

      Function mobileProfileLinks has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const mobileProfileLinks = function mobileProfileLinks(username, isAdmin, router, location, customColor, unReadMessagesCount) {
  if (username) {
    const notificationBadgeInArray = unReadMessagesCount > 0 ?
      [r(NotificationBadge, { className: css.notificationBadge, countClassName: css.notificationBadgeCount }, unReadMessagesCount)] :
      [];
      Severity: Minor
      Found in client/app/components/sections/Topbar/Topbar.js - About 1 hr to fix

        Function mobileProfileLinks has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        const mobileProfileLinks = function mobileProfileLinks(username, isAdmin, router, location, customColor, unReadMessagesCount) {
        Severity: Minor
        Found in client/app/components/sections/Topbar/Topbar.js - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            const translations = {
    inbox: t('web.topbar.inbox'),
    listings: t('web.topbar.listings'),
    profile: t('web.topbar.profile'),
    settings: t('web.topbar.settings'),
          Severity: Major
          Found in client/app/components/sections/Topbar/Topbar.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/stripe_form3.js on lines 131..138

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status