Sign upLogin

sharetribe/sharetribe

View on GitHub
Star
client/app/specs/ManageAvailabilityReducer.spec.js

Summary

Maintainability
F
3 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('ignores a block to a booked day', () => {
      const state = reducer(stateTodayBooked(), actions.blockDay(TODAY));
      expect(state.get('booked_dates').length).to.equal(1);
      expect(state.get('initial_blocked_dates').length).to.equal(0);
      expect(state.get('blocked_dates').length).to.equal(0);
Severity: Major
Found in client/app/specs/ManageAvailabilityReducer.spec.js and 1 other location - About 7 hrs to fix
client/app/specs/ManageAvailabilityReducer.spec.js on lines 132..139

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 179.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('ignores an allow to a booked day', () => {
      const state = reducer(stateTodayBooked(), actions.unblockDay(TODAY));
      expect(state.get('booked_dates').length).to.equal(1);
      expect(state.get('initial_blocked_dates').length).to.equal(0);
      expect(state.get('blocked_dates').length).to.equal(0);
Severity: Major
Found in client/app/specs/ManageAvailabilityReducer.spec.js and 1 other location - About 7 hrs to fix
client/app/specs/ManageAvailabilityReducer.spec.js on lines 141..148

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 179.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('allows an initially blocked day', () => {
      const state = reducer(stateTodayBlocked(), actions.unblockDay(TODAY));
      expect(state.get('initial_blocked_dates').length).to.equal(1);
      expect(state.get('blocked_dates').length).to.equal(1);
      expect(hasChanges(state)).to.equal(true);
Severity: Major
Found in client/app/specs/ManageAvailabilityReducer.spec.js and 1 other location - About 5 hrs to fix
client/app/specs/ManageAvailabilityReducer.spec.js on lines 124..130

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 148.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('allows an initially allowed day', () => {
      const state = reducer(stateEmpty(), actions.unblockDay(TODAY));
      expect(state.get('initial_blocked_dates').length).to.equal(0);
      expect(state.get('blocked_dates').length).to.equal(0);
      expect(hasChanges(state)).to.equal(false);
Severity: Major
Found in client/app/specs/ManageAvailabilityReducer.spec.js and 1 other location - About 5 hrs to fix
client/app/specs/ManageAvailabilityReducer.spec.js on lines 102..108

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 148.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status