Sign upLogin

showdownjs/showdown

View on GitHub
Star
src/converter.js

Summary

Maintainability
F
6 days
Test Coverage

Function Converter has a Cognitive Complexity of 151 (exceeds 5 allowed). Consider refactoring.
Open

showdown.Converter = function (converterOptions) {
  'use strict';

  var
      /**
Severity: Minor
Found in src/converter.js - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Converter has 330 lines of code (exceeds 25 allowed). Consider refactoring.
Open

showdown.Converter = function (converterOptions) {
  'use strict';

  var
      /**
Severity: Major
Found in src/converter.js - About 1 day to fix

File converter.js has 333 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Created by Estevao on 31-05-2015.
 */

/**
Severity: Minor
Found in src/converter.js - About 4 hrs to fix

Function makeMarkdown has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  this.makeMarkdown = function (src) {

    // replace \r\n with \n
    src = src.replace(/\r\n/g, '\n');
    src = src.replace(/\r/g, '\n'); // old macs
Severity: Major
Found in src/converter.js - About 2 hrs to fix

Function makeHtml has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  this.makeHtml = function (text) {
    //check if text is not falsy
    if (!text) {
      return text;
    }
Severity: Major
Found in src/converter.js - About 2 hrs to fix

Function _parseExtension has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function _parseExtension (ext, name) {

    name = name || null;
    // If it's a string, the extension was previously loaded
    if (showdown.helper.isString(ext)) {
Severity: Minor
Found in src/converter.js - About 1 hr to fix

Function substitutePreCodeTags has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function substitutePreCodeTags (doc) {

      var pres = doc.querySelectorAll('pre'),
          presPH = [];
Severity: Minor
Found in src/converter.js - About 1 hr to fix

Avoid deeply nested control flow statements.
Open

              if (matches !== null) {
                language = matches[1];
                break;
              }
Severity: Major
Found in src/converter.js - About 45 mins to fix

Function _dispatch has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  this._dispatch = function dispatch (evtName, text, options, globals, pParams) {
Severity: Minor
Found in src/converter.js - About 35 mins to fix

TODO found
Open

    // TODO
Severity: Minor
Found in src/converter.js by fixme

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      for (var i = 0; i < langExtensions.length; ++i) {
        if (langExtensions[i] === ext) {
          langExtensions.splice(i, 1);
        }
      }
Severity: Minor
Found in src/converter.js and 1 other location - About 55 mins to fix
src/converter.js on lines 538..542

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      for (var ii = 0; ii < outputModifiers.length; ++ii) {
        if (outputModifiers[ii] === ext) {
          outputModifiers.splice(ii, 1);
        }
      }
Severity: Minor
Found in src/converter.js and 1 other location - About 55 mins to fix
src/converter.js on lines 533..537

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

    showdown.helper.forEach(langExtensions, function (ext) {
      text = showdown.subParser('makehtml.runExtension')(ext, text, options, globals);
    });
Severity: Minor
Found in src/converter.js and 1 other location - About 40 mins to fix
src/converter.js on lines 346..348

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

    showdown.helper.forEach(outputModifiers, function (ext) {
      text = showdown.subParser('makehtml.runExtension')(ext, text, options, globals);
    });
Severity: Minor
Found in src/converter.js and 1 other location - About 40 mins to fix
src/converter.js on lines 321..323

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status