Sign upLogin

showdownjs/showdown

View on GitHub
Star
src/subParsers/makehtml/lists.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function processListItems has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function processListItems (listStr, trimTrailing) {
    // The $g_list_level global keeps track of when we're inside a list.
    // Each time we enter a list, we increment it; when we leave a list,
    // we decrement. If it's zero, we're not in a list anymore.
    //
Severity: Major
Found in src/subParsers/makehtml/lists.js - About 3 hrs to fix

TODO found
Open

        // TODO: This is a copy of the paragraph parser
Severity: Minor
Found in src/subParsers/makehtml/lists.js by fixme

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for (var i = 0; i < end; i++) {
          var str = grafs[i];
          // if this is an HTML marker, copy it
          if (str.search(/ยจ([KG])(\d+)\1/g) >= 0) {
            grafsOut.push(str);
Severity: Major
Found in src/subParsers/makehtml/lists.js and 1 other location - About 4 hrs to fix
src/subParsers/makehtml/paragraphs.js on lines 16..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status