Sign upLogin

shubinmi/salesforce-bulk-api

View on GitHub
Star

Showing 6 of 6 total issues

Function getErrors has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function getErrors()
    {
        $errors = [];
        foreach ($this->job->getBatchesInfo() as $batchInfoDto) {
            $error = new SFBatchErrors();
Severity: Minor
Found in src/services/JobSFApiService.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

JobInfoDto has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

class JobInfoDto extends ConstructFromArrayOrJson
{
    const STATE_OPEN    = 'Open';
    const STATE_CLOSED  = 'Closed';
    const STATE_ABORTED = 'Aborted';
Severity: Minor
Found in src/dto/JobInfoDto.php - About 2 hrs to fix

    Method login has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function login(ApiSalesforce $api)
    {
        $asWho          = $api->getLoginParams()->amIPartner() ? 'u' : 'c';
        $version        = $api->getLoginParams()->getApiVersion();
        $endpointPrefix = $api->getLoginParams()->getEndpointPrefix();
    Severity: Minor
    Found in src/api/UserApiSF.php - About 1 hr to fix

      Method getErrors has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getErrors()
    {
        $errors = [];
        foreach ($this->job->getBatchesInfo() as $batchInfoDto) {
            $error = new SFBatchErrors();
      Severity: Minor
      Found in src/services/JobSFApiService.php - About 1 hr to fix

        Function getQueriesResults has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getQueriesResults()
    {
        if (!$this->job->getBatchesResults()) {
            return [];
        }
        Severity: Minor
        Found in src/services/JobSFApiService.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function login(ApiSalesforce $api)
    {
        $asWho          = $api->getLoginParams()->amIPartner() ? 'u' : 'c';
        $version        = $api->getLoginParams()->getApiVersion();
        $endpointPrefix = $api->getLoginParams()->getEndpointPrefix();
        Severity: Minor
        Found in src/api/UserApiSF.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language