shuoyao/BirdGo

View on GitHub
app/assets/javascripts/explorer/init_map.js

Summary

Maintainability
F
3 days
Test Coverage

Function markTheseData has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function markTheseData(data) {
  map = document.map
  map.clearOverlays();

  for (var i = 0; i < data.length; i++) {
Severity: Major
Found in app/assets/javascripts/explorer/init_map.js - About 2 hrs to fix

    Function markTheseDataWithoutClearingBefore has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function markTheseDataWithoutClearingBefore(data) {
      map = document.map
      console.log(data)
    
      for (var i = 0; i < data.length; i++) {
    Severity: Minor
    Found in app/assets/javascripts/explorer/init_map.js - About 1 hr to fix

      Function initMap has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function initMap() {
        if (document.geoReady == undefined) {
          return;
        }
        var map = new google.maps.Map(document.getElementById('map'), {
      Severity: Minor
      Found in app/assets/javascripts/explorer/init_map.js - About 1 hr to fix

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

                contentString = '<div id="content">'+
                 '<div id="siteNotice">'+
                 '</div>' + '<div id="bodyContent">'+
                 '<p><b>'
                  + abird['sciName']
        Severity: Major
        Found in app/assets/javascripts/explorer/init_map.js and 2 other locations - About 5 hrs to fix
        app/assets/javascripts/explorer/init_map.js on lines 76..89
        app/assets/javascripts/explorer/init_map.js on lines 155..168

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 136.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

              contentString = '<div id="content">'+
               '<div id="siteNotice">'+
               '</div>' + '<div id="bodyContent">'+
               '<p><b>'
                + abird['sciName']
        Severity: Major
        Found in app/assets/javascripts/explorer/init_map.js and 2 other locations - About 5 hrs to fix
        app/assets/javascripts/explorer/init_map.js on lines 76..89
        app/assets/javascripts/explorer/init_map.js on lines 113..126

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 136.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

              contentString = '<div id="content">'+
               '<div id="siteNotice">'+
               '</div>' + '<div id="bodyContent">'+
               '<p><b>'
                + abird['sciName']
        Severity: Major
        Found in app/assets/javascripts/explorer/init_map.js and 2 other locations - About 5 hrs to fix
        app/assets/javascripts/explorer/init_map.js on lines 113..126
        app/assets/javascripts/explorer/init_map.js on lines 155..168

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 136.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                var marker = new google.maps.Marker({
                  position: {lat: parseFloat(abird.lat), lng: parseFloat(abird.lng)},
                  map: map,
                  icon: 'https://developers.google.com/maps/documentation/javascript/examples/full/images/beachflag.png'
                });
        Severity: Major
        Found in app/assets/javascripts/explorer/init_map.js and 1 other location - About 1 hr to fix
        app/assets/javascripts/explorer/init_map.js on lines 148..152

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              var marker = new google.maps.Marker({
                position: {lat: parseFloat(abird.lat), lng: parseFloat(abird.lng)},
                map: map,
                icon: 'https://developers.google.com/maps/documentation/javascript/examples/full/images/beachflag.png'
              });
        Severity: Major
        Found in app/assets/javascripts/explorer/init_map.js and 1 other location - About 1 hr to fix
        app/assets/javascripts/explorer/init_map.js on lines 106..110

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function fetchDataAtLocationAndShowWithoutClearingBefore(url) {
          $.ajax({
            url: url,
            method: "GET",
            // "BirdGo.com/eBirdData/NearesrBIrds/lng=xxx&lat=xxx&r=xxx&t=xxx"
        Severity: Major
        Found in app/assets/javascripts/explorer/init_map.js and 1 other location - About 1 hr to fix
        app/assets/javascripts/explorer/init_map.js on lines 38..49

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function fetchDataAtLocationAndShow(url) {
          $.ajax({
            url: url,
            method: "GET",
            // "BirdGo.com/eBirdData/NearesrBIrds/lng=xxx&lat=xxx&r=xxx&t=xxx"
        Severity: Major
        Found in app/assets/javascripts/explorer/init_map.js and 1 other location - About 1 hr to fix
        app/assets/javascripts/explorer/init_map.js on lines 51..62

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status