sicambria/skilltree

View on GitHub

Showing 240 of 537 total issues

Function addTraining has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function addTraining () {
    var modal = document.getElementById("addTrainingModal");
    modal.style.display = "block";

    var span = document.getElementById("closeTrainingModal");
Severity: Major
Found in new design/draft_create_skill_modal_design/user/chartandtree.js - About 2 hrs to fix

    Function onclick has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        save.onclick = function () {
            var pointsTable = document.getElementById('pointsTable');
            var pointsNum = pointsTable.rows.length - 1;
            var pointDescription = [];
            for (i = 1; i < pointsNum + 1; ++i) pointDescription.push(pointsTable.rows[i].cells[1].children[0].value);
    Severity: Major
    Found in public/user/chartandtree.js - About 2 hrs to fix

      Function getPublicSkillData has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function getPublicSkillData(){
        var skillToSearch = {value: document.getElementById('cardSearchBar').value};
        document.getElementById("searchModalTitle").innerHTML = "Click on a skill, to view its details!";
        request('POST', '/protected/getPublicSkillData', skillToSearch, function() {
            if(this.readyState == 4 && this.status == 200) {
      Severity: Major
      Found in new design/draft_offers_modal_design/user/src/search.js - About 2 hrs to fix

        Function onclick has 55 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            save.onclick = function () {
                var pointsTable = document.getElementById('pointsTable');
                var pointsNum = pointsTable.rows.length - 1;
                var pointDescription = [];
                for (i = 1; i < pointsNum + 1; ++i) pointDescription.push(pointsTable.rows[i].cells[1].children[0].value);
        Severity: Major
        Found in new design/draft_offers_modal_design/user/chartandtree.js - About 2 hrs to fix

          Function onclick has 55 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              save.onclick = function () {
                  var pointsTable = document.getElementById('pointsTable');
                  var pointsNum = pointsTable.rows.length - 1;
                  var pointDescription = [];
                  for (i = 1; i < pointsNum + 1; ++i) pointDescription.push(pointsTable.rows[i].cells[1].children[0].value);
          Severity: Major
          Found in new design/draft_offers_modal_design/user/chartandtree.js - About 2 hrs to fix

            Function toggleSkillInfoPage has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

                toggleSkillInfoPage () {
                    var modal = document.getElementById('skillinfopage');
                    var header = document.getElementById('infoSkillnameHeader');
                    var span = document.getElementById("closeInfoModal");
                    var desc = document.getElementById("imDesc");
            Severity: Minor
            Found in public/user/classes/itemcontainer.js - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getPublicSkillData has 52 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function getPublicSkillData(){
              var skillToSearch = {value: document.getElementById('cardSearchBar').value};
              request('POST', '/protected/getPublicSkillData', skillToSearch, function() {
                  if(this.readyState == 4 && this.status == 200) {
                    var modal = document.getElementById('searchModal');
            Severity: Major
            Found in new design/draft_create_skill_modal_design/user/src/search.js - About 2 hrs to fix

              Function addTraining has 50 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function addTraining () {
                  document.getElementById('addTrainingForm').reset();
              
                  var modal = document.getElementById("addTrainingModal");
                  modal.style.display = "block";
              Severity: Minor
              Found in public/user/chartandtree.js - About 2 hrs to fix

                Function addTraining has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function addTraining () {
                    document.getElementById('addTrainingForm').reset();
                
                    var modal = document.getElementById("addTrainingModal");
                    modal.style.display = "block";
                Severity: Minor
                Found in new design/draft_offers_modal_design/user/chartandtree.js - About 2 hrs to fix

                  Function showChart has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function showChart() {
                      document.getElementById('creator').style.display = "none";
                      document.getElementById('approveTrees').style.display = "none";
                      document.getElementById('approveSkills').style.display = "none";
                      document.getElementById('pixiCanvas').style.display = "block";
                  Severity: Minor
                  Found in public/user/src/display.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function showChart has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function showChart() {
                      document.getElementById('creator').style.display = "none";
                      document.getElementById('approveTrees').style.display = "none";
                      document.getElementById('approveSkills').style.display = "none";
                      document.getElementById('pixiCanvas').style.display = "block";
                  Severity: Minor
                  Found in new design/draft_create_skill_modal_design/user/src/display.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function constructor has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                      constructor(app, skills, skillName, owner) {
                          this.app = app;
                          this.skills = skills;
                          this.skill = skills.find(obj => obj.name == skillName);
                          this.self = owner.self;

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function showChart has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function showChart() {
                      document.getElementById('creator').style.display = "none";
                      document.getElementById('approveTrees').style.display = "none";
                      document.getElementById('approveSkills').style.display = "none";
                      document.getElementById('pixiCanvas').style.display = "block";
                  Severity: Minor
                  Found in new design/draft_offers_modal_design/user/src/display.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function onclick has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      save.onclick = function () {
                          var pointsTable = document.getElementById('pointsTable');
                          var pointsNum = pointsTable.rows.length - 1;
                          var pointDescription = [];
                          for (i = 1; i < pointsNum + 1; ++i) pointDescription.push(pointsTable.rows[i].cells[1].children[0].value);
                  Severity: Minor
                  Found in public/user/chartandtree.js - About 1 hr to fix

                    Function onclick has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        save.onclick = function () {
                            var pointsTable = document.getElementById('pointsTable');
                            var pointsNum = pointsTable.rows.length - 1;
                            var pointDescription = [];
                            for (i = 1; i < pointsNum + 1; ++i) pointDescription.push(pointsTable.rows[i].cells[1].children[0].value);
                    Severity: Minor
                    Found in new design/draft_create_skill_modal_design/user/chartandtree.js - About 1 hr to fix

                      Function onclick has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          save.onclick = function () {
                              var pointsTable = document.getElementById('pointsTable');
                              var pointsNum = pointsTable.rows.length - 1;
                              var pointDescription = [];
                              for (i = 1; i < pointsNum + 1; ++i) pointDescription.push(pointsTable.rows[i].cells[1].children[0].value);
                      Severity: Minor
                      Found in new design/draft_create_skill_modal_design/user/chartandtree.js - About 1 hr to fix

                        Function onclick has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            save.onclick = function () {
                                var pointsTable = document.getElementById('pointsTable');
                                var pointsNum = pointsTable.rows.length - 1;
                                var pointDescription = [];
                                for (i = 1; i < pointsNum + 1; ++i) pointDescription.push(pointsTable.rows[i].cells[1].children[0].value);
                        Severity: Minor
                        Found in new design/draft_offers_modal_design/user/chartandtree.js - About 1 hr to fix

                          Function toggleSkillInfoPage has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                          Open

                              toggleSkillInfoPage () {
                                  var modal = document.getElementById('skillinfopage');
                                  var header = document.getElementById('infoSkillnameHeader');
                                  var span = document.getElementById("closeInfoModal");
                                  var desc = document.getElementById("imDesc");

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function toggleSkillInfoPage has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                          Open

                              toggleSkillInfoPage () {
                                  var modal = document.getElementById('skillinfopage');
                                  var header = document.getElementById('infoSkillnameHeader');
                                  var span = document.getElementById("closeInfoModal");
                                  var desc = document.getElementById("imDesc");
                          Severity: Minor
                          Found in new design/draft_offers_modal_design/user/classes/itemcontainer.js - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function pushTexture has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                  LayerTextureCache.prototype.pushTexture = function (renderer) {
                                      var screen = renderer.screen;
                                      if (!this.renderTexture) {
                                          this.initRenderTexture(renderer);
                                      }
                          Severity: Minor
                          Found in new design/draft_create_skill_modal_design/user/pixi/pixi-layers.js - About 1 hr to fix
                            Severity
                            Category
                            Status
                            Source
                            Language