Sign upLogin

signmeup/signmeup

View on GitHub
Star
imports/api/queues/methods.js

Summary

Maintainability
D
3 days
Test Coverage

File methods.js has 434 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Meteor } from "meteor/meteor";
import { ValidatedMethod } from "meteor/mdg:validated-method";
import { SimpleSchema } from "meteor/aldeed:simple-schema";
import { Roles } from "meteor/alanning:roles";
import { Jobs } from "meteor/msavin:sjobs";
Severity: Minor
Found in imports/api/queues/methods.js - About 6 hrs to fix

    Function run has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      run({ queueId }) {
    const queue = Queues.findOne(queueId);
    if (!queue) {
      throw new Meteor.Error(
        "queues.doesNotExist",
    Severity: Major
    Found in imports/api/queues/methods.js - About 2 hrs to fix

      Function run has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        run({ queueId, name, locationId, scheduledEndTime }) {
    const queue = Queues.findOne(queueId);
    if (!queue || queue.status === "ended") {
      throw new Meteor.Error(
        "queues.doesNotExist"`No queue exists with id ${queueId}`
      Severity: Minor
      Found in imports/api/queues/methods.js - About 1 hr to fix

        Function run has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          run({ queueId }) {
    const queue = Queues.findOne(queueId);
    if (!queue || queue.status === "ended") {
      throw new Meteor.Error(
        "queues.doesNotExist"`No queue exists with id ${queueId}`
        Severity: Minor
        Found in imports/api/queues/methods.js - About 1 hr to fix

          Function run has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            run({ name, courseId, locationId, scheduledEndTime }) {
    if (!Courses.findOne(courseId)) {
      throw new Meteor.Error(
        "courses.doesNotExist",
        `No course exists with id ${courseId}`
          Severity: Minor
          Found in imports/api/queues/methods.js - About 1 hr to fix

            Function run has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              run({ queueId }) {
    const queue = Queues.findOne(queueId);
    if (!queue || queue.status === "ended") {
      throw new Meteor.Error(
        "queues.doesNotExist",
            Severity: Minor
            Found in imports/api/queues/methods.js - About 1 hr to fix

              Function run has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                run({ queueId, name, userAgent, secret }) {
    const queue = Queues.findOne(queueId);
    if (!queue) {
      throw new Meteor.Error(
        "queues.doesNotExist",
              Severity: Minor
              Found in imports/api/queues/methods.js - About 1 hr to fix

                Function run has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  run({ queueId }) {
    const queue = Queues.findOne(queueId);
    if (!queue || queue.status === "ended") {
      throw new Meteor.Error(
        "queues.doesNotExist"`No queue exists with id ${queueId}`
                Severity: Minor
                Found in imports/api/queues/methods.js - About 1 hr to fix

                  Function run has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    run({ queueId }) {
    const queue = Queues.findOne(queueId);
    if (!queue || queue.status === "ended") {
      throw new Meteor.Error(
        "queues.doesNotExist"`No queue exists with id ${queueId}`
                  Severity: Minor
                  Found in imports/api/queues/methods.js - About 1 hr to fix

                    Function run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                      run({ queueId, name, locationId, scheduledEndTime }) {
    const queue = Queues.findOne(queueId);
    if (!queue || queue.status === "ended") {
      throw new Meteor.Error(
        "queues.doesNotExist"`No queue exists with id ${queueId}`
                    Severity: Minor
                    Found in imports/api/queues/methods.js - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      run({ queueId, sessionId }) {
    const queue = Queues.findOne(queueId);
    if (!queue) {
      throw new Meteor.Error(
        "queues.doesNotExist",
                    Severity: Minor
                    Found in imports/api/queues/methods.js - About 1 hr to fix

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          if (
      this.connection &&
      !Roles.userIsInRole(
        this.userId,
        ["admin", "mta", "hta", "ta"],
                      Severity: Major
                      Found in imports/api/queues/methods.js and 2 other locations - About 55 mins to fix
                      imports/api/queues/methods.js on lines 240..253
                      imports/api/queues/methods.js on lines 298..311

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 54.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          if (
      this.connection &&
      !Roles.userIsInRole(
        this.userId,
        ["admin", "mta", "hta", "ta"],
                      Severity: Major
                      Found in imports/api/queues/methods.js and 2 other locations - About 55 mins to fix
                      imports/api/queues/methods.js on lines 240..253
                      imports/api/queues/methods.js on lines 351..364

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 54.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          if (
      this.connection &&
      !Roles.userIsInRole(
        this.userId,
        ["admin", "mta", "hta", "ta"],
                      Severity: Major
                      Found in imports/api/queues/methods.js and 2 other locations - About 55 mins to fix
                      imports/api/queues/methods.js on lines 298..311
                      imports/api/queues/methods.js on lines 351..364

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 54.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          Queues.update(
      {
        _id: queueId
      },
      {
                      Severity: Minor
                      Found in imports/api/queues/methods.js and 1 other location - About 50 mins to fix
                      imports/api/tickets/methods.js on lines 287..302

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 51.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Unknown word (CssSyntaxError)
                      Open

                      import { Meteor } from "meteor/meteor";
                      Severity: Minor
                      Found in imports/api/queues/methods.js by stylelint

                      There are no issues that match your filters.

                      Category
                      Status