Sign upLogin

signmeup/signmeup

View on GitHub
Star
imports/api/tickets/methods.js

Summary

Maintainability
F
1 wk
Test Coverage

File methods.js has 442 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Meteor } from "meteor/meteor";
import { ValidatedMethod } from "meteor/mdg:validated-method";
import { SimpleSchema } from "meteor/aldeed:simple-schema";
import { Jobs } from "meteor/msavin:sjobs";
import { Roles } from "meteor/alanning:roles";
Severity: Minor
Found in imports/api/tickets/methods.js - About 6 hrs to fix

    Function run has 115 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      run({
    queueId,
    studentEmails,
    question,
    notifications,
    Severity: Major
    Found in imports/api/tickets/methods.js - About 4 hrs to fix

      Function run has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

        run({
    queueId,
    studentEmails,
    question,
    notifications,
      Severity: Minor
      Found in imports/api/tickets/methods.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function run has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        run({ ticketId }) {
    const ticket = Tickets.findOne(ticketId);
    if (!ticket || ticket.status === "deleted") {
      throw new Meteor.Error(
        "tickets.doesNotExist"`No ticket exists with id ${ticketId}`
      Severity: Minor
      Found in imports/api/tickets/methods.js - About 1 hr to fix

        Function run has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          run({ ticketId }) {
    const ticket = Tickets.findOne(ticketId);
    if (!ticket || ticket.status === "deleted") {
      throw new Meteor.Error(
        "tickets.doesNotExist"`No ticket exists with id ${ticketId}`
        Severity: Minor
        Found in imports/api/tickets/methods.js - About 1 hr to fix

          Function run has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            run({ ticketId }) {
    const ticket = Tickets.findOne(ticketId);
    if (!ticket || ticket.status === "deleted") {
      throw new Meteor.Error(
        "tickets.doesNotExist"`No ticket exists with id ${ticketId}`
          Severity: Minor
          Found in imports/api/tickets/methods.js - About 1 hr to fix

            Function run has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              run({ ticketId }) {
    const ticket = Tickets.findOne(ticketId);
    if (!ticket || ticket.status === "deleted") {
      throw new Meteor.Error(
        "tickets.doesNotExist"`No ticket exists with id ${ticketId}`
            Severity: Minor
            Found in imports/api/tickets/methods.js - About 1 hr to fix

              Function run has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                run({ ticketId }) {
    const ticket = Tickets.findOne(ticketId);
    if (!ticket) {
      throw new Meteor.Error(
        "tickets.doesNotExist"`No ticket exists with id ${ticketId}`
              Severity: Minor
              Found in imports/api/tickets/methods.js - About 1 hr to fix

                Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  run({ ticketId }) {
    const ticket = Tickets.findOne(ticketId);
    if (!ticket || ticket.status === "deleted") {
      throw new Meteor.Error(
        "tickets.doesNotExist"`No ticket exists with id ${ticketId}`
                Severity: Minor
                Found in imports/api/tickets/methods.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                export const claimTicket = new ValidatedMethod({
  name: "tickets.claimTicket",
  validate: new SimpleSchema({
    ticketId: { type: String, regEx: SimpleSchema.RegEx.Id }
  }).validator(),
                Severity: Major
                Found in imports/api/tickets/methods.js and 1 other location - About 1 day to fix
                imports/api/tickets/methods.js on lines 367..413

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 272.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                export const markTicketAsDone = new ValidatedMethod({
  name: "tickets.markTicketAsDone",
  validate: new SimpleSchema({
    ticketId: { type: String, regEx: SimpleSchema.RegEx.Id }
  }).validator(),
                Severity: Major
                Found in imports/api/tickets/methods.js and 1 other location - About 1 day to fix
                imports/api/tickets/methods.js on lines 209..255

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 272.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                export const notifyTicketByText = new ValidatedMethod({
  name: "tickets.notifyTicketByText",
  validate: new SimpleSchema({
    ticketId: { type: String, regEx: SimpleSchema.RegEx.Id }
  }).validator(),
                Severity: Major
                Found in imports/api/tickets/methods.js and 1 other location - About 5 hrs to fix
                imports/api/tickets/methods.js on lines 462..480

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 143.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                export const notifyTicketByEmail = new ValidatedMethod({
  name: "tickets.notifyTicketByEmail",
  validate: new SimpleSchema({
    ticketId: { type: String, regEx: SimpleSchema.RegEx.Id }
  }).validator(),
                Severity: Major
                Found in imports/api/tickets/methods.js and 1 other location - About 5 hrs to fix
                imports/api/tickets/methods.js on lines 482..500

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 143.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    Tickets.update(
      {
        _id: ticketId
      },
      {
                Severity: Minor
                Found in imports/api/tickets/methods.js and 1 other location - About 50 mins to fix
                imports/api/queues/methods.js on lines 166..181

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Unknown word (CssSyntaxError)
                Open

                import { Meteor } from "meteor/meteor";
                Severity: Minor
                Found in imports/api/tickets/methods.js by stylelint

                There are no issues that match your filters.

                Category
                Status