signmeup/signmeup

View on GitHub
imports/lib/both/notifications.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function sendTextNotification has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static sendTextNotification(ticket) {
    const queue = Queues.findOne(ticket.queueId);
    if (!queue) {
      throw new Meteor.Error(
        "queues.doesNotExist",
Severity: Minor
Found in imports/lib/both/notifications.js - About 1 hr to fix

    Function sendEmailNotification has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      static sendEmailNotification(ticket) {
        const queue = Queues.findOne(ticket.queueId);
        if (!queue) {
          throw new Meteor.Error(
            "queues.doesNotExist",
    Severity: Minor
    Found in imports/lib/both/notifications.js - About 1 hr to fix

      Function sendEmailNotification has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        static sendEmailNotification(ticket) {
          const queue = Queues.findOne(ticket.queueId);
          if (!queue) {
            throw new Meteor.Error(
              "queues.doesNotExist",
      Severity: Minor
      Found in imports/lib/both/notifications.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function sendTextNotification has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        static sendTextNotification(ticket) {
          const queue = Queues.findOne(ticket.queueId);
          if (!queue) {
            throw new Meteor.Error(
              "queues.doesNotExist",
      Severity: Minor
      Found in imports/lib/both/notifications.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Unknown word (CssSyntaxError)
      Open

      import { Meteor } from "meteor/meteor";
      Severity: Minor
      Found in imports/lib/both/notifications.js by stylelint

      There are no issues that match your filters.

      Category
      Status