Sign upLogin

signmeup/signmeup

View on GitHub
Star
imports/ui/components/modals/modal-join-queue/modal-join-queue.js

Summary

Maintainability
D
2 days
Test Coverage

Function submit #js-modal-join-queue-form has 81 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  "submit #js-modal-join-queue-form"(event, templateInstance) {
    event.preventDefault();
    let errors = false;

    let data = {
Severity: Major
Found in imports/ui/components/modals/modal-join-queue/modal-join-queue.js - About 3 hrs to fix

    File modal-join-queue.js has 279 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { Meteor } from "meteor/meteor";
import { Template } from "meteor/templating";
import { ReactiveArray } from "meteor/manuel:reactivearray";
import { ReactiveDict } from "meteor/reactive-dict";
import { SimpleSchema } from "meteor/aldeed:simple-schema";
    Severity: Minor
    Found in imports/ui/components/modals/modal-join-queue/modal-join-queue.js - About 2 hrs to fix

      Function submit #js-modal-join-queue-form has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

        "submit #js-modal-join-queue-form"(event, templateInstance) {
    event.preventDefault();
    let errors = false;

    let data = {
      Severity: Minor
      Found in imports/ui/components/modals/modal-join-queue/modal-join-queue.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function onCreated has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Template.ModalJoinQueue.onCreated(function onCreated() {
  this.errors = new ReactiveDict();

  this.studentEmails = new ReactiveArray([]);
  this.addStudentEmail = (email, callback) => {
      Severity: Minor
      Found in imports/ui/components/modals/modal-join-queue/modal-join-queue.js - About 1 hr to fix

        Function addStudentEmail has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          this.addStudentEmail = (email, callback) => {
    email = email.toLowerCase(); // eslint-disable-line no-param-reassign
    try {
      new SimpleSchema({
        email: {
        Severity: Minor
        Found in imports/ui/components/modals/modal-join-queue/modal-join-queue.js - About 1 hr to fix

          Function onCreated has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          Template.ModalJoinQueue.onCreated(function onCreated() {
  this.errors = new ReactiveDict();

  this.studentEmails = new ReactiveArray([]);
  this.addStudentEmail = (email, callback) => {
          Severity: Minor
          Found in imports/ui/components/modals/modal-join-queue/modal-join-queue.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (!$.trim(question)) {
      Template.instance().errors.set("question", "Please enter a question.");
      errors = true;
    } else {
      data.question = question;
          Severity: Major
          Found in imports/ui/components/modals/modal-join-queue/modal-join-queue.js and 1 other location - About 1 hr to fix
          imports/ui/components/modals/modal-join-queue/modal-join-queue.js on lines 248..256

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if (!$.trim(preferredName)) {
        Template.instance().errors.set(
          "current-student",
          "Please enter your name."
        );
          Severity: Major
          Found in imports/ui/components/modals/modal-join-queue/modal-join-queue.js and 1 other location - About 1 hr to fix
          imports/ui/components/modals/modal-join-queue/modal-join-queue.js on lines 271..276

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                if (email.length > 0) {
        Template.instance().addStudentEmail(email, () => {
          $(".js-email-input").val("");
        });
      }
          Severity: Minor
          Found in imports/ui/components/modals/modal-join-queue/modal-join-queue.js and 1 other location - About 55 mins to fix
          imports/ui/components/modals/modal-join-queue/modal-join-queue.js on lines 188..192

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              if (email.length > 0) {
      Template.instance().addStudentEmail(email, () => {
        $(".js-email-input").val("");
      });
    }
          Severity: Minor
          Found in imports/ui/components/modals/modal-join-queue/modal-join-queue.js and 1 other location - About 55 mins to fix
          imports/ui/components/modals/modal-join-queue/modal-join-queue.js on lines 178..182

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                Template.instance()
        .studentEmails.array()
        .filter(email => !user || user.emailAddress() !== email).length > 0
          Severity: Minor
          Found in imports/ui/components/modals/modal-join-queue/modal-join-queue.js and 1 other location - About 50 mins to fix
          imports/ui/components/modals/modal-join-queue/modal-join-queue.js on lines 119..122

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              const students = Template.instance()
      .studentEmails.array()
      .filter(email => !user || user.emailAddress() !== email)
      .map(emailToStudent);
          Severity: Minor
          Found in imports/ui/components/modals/modal-join-queue/modal-join-queue.js and 1 other location - About 50 mins to fix
          imports/ui/components/modals/modal-join-queue/modal-join-queue.js on lines 111..113

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                new SimpleSchema({
        email: {
          type: String,
          regEx: SimpleSchema.RegEx.Email
        }
          Severity: Minor
          Found in imports/ui/components/modals/modal-join-queue/modal-join-queue.js and 1 other location - About 35 mins to fix
          imports/api/courses/server/publications.js on lines 9..11

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Unknown word (CssSyntaxError)
          Open

          import { Meteor } from "meteor/meteor";
          Severity: Minor
          Found in imports/ui/components/modals/modal-join-queue/modal-join-queue.js by stylelint

          There are no issues that match your filters.

          Category
          Status