Function exportarParaLexML
has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring. Open
function exportarParaLexML(dispositivoDOM, rotulos) {
var cntArtigos = 0;
if (!rotulos) {
rotulos = padrao.rotulo;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function exportarParaLexML
has 143 lines of code (exceeds 25 allowed). Consider refactoring. Open
function exportarParaLexML(dispositivoDOM, rotulos) {
var cntArtigos = 0;
if (!rotulos) {
rotulos = padrao.rotulo;
File exportarParaLexML.js
has 314 lines of code (exceeds 250 allowed). Consider refactoring. Open
/* Copyright 2017 Assembleia Legislativa de Minas Gerais
*
* This file is part of Editor-Articulacao.
*
* Editor-Articulacao is free software: you can redistribute it and/or modify
Function criarRotuloLexML
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
function criarRotuloLexML(tipo, numero, unico, nEmenda, rotulos) {
var elemento = document.createElementNS('http://www.lexml.gov.br/1.0', 'Rotulo');
switch (tipo) {
case 'Artigo':
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function normalizarParagrafo
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
function normalizarParagrafo(paragrafo) {
while (paragrafo.hasAttributes()) {
paragrafo.removeAttribute(paragrafo.attributes[0].name);
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function criarRotuloLexML
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
function criarRotuloLexML(tipo, numero, unico, nEmenda, rotulos) {
var elemento = document.createElementNS('http://www.lexml.gov.br/1.0', 'Rotulo');
switch (tipo) {
case 'Artigo':
Function criarConteudoInline
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
function criarConteudoInline(origem, destino) {
var arvore = document.createTreeWalker(origem, NodeFilter.SHOW_ELEMENT | NodeFilter.SHOW_TEXT, null /* necesário no IE 11 */, null /* necesário no IE 11 */);
var atual = {
/**
* Objeto de contexto de exportação anterior (este mesmo objeto)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function criarConteudoInline
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
function criarConteudoInline(origem, destino) {
var arvore = document.createTreeWalker(origem, NodeFilter.SHOW_ELEMENT | NodeFilter.SHOW_TEXT, null /* necesário no IE 11 */, null /* necesário no IE 11 */);
var atual = {
/**
* Objeto de contexto de exportação anterior (este mesmo objeto)
Function possuiSubtipo
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
possuiSubtipo(subtipo) {
switch (this.tipo) {
case 'Articulacao':
return subtipo === 'Artigo' || subtipo === 'Titulo' || subtipo === 'Capitulo' || subtipo === 'Secao' || subtipo === 'Livro' || subtipo === 'Parte';
Function criarElementoLexML
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
function criarElementoLexML(tipo, conteudo, idPai, idxFilho, unico, nEmenda, rotulos) {
var elemento, id;
id = tipo.substr(0, 3).toLowerCase();
id = idPai ? idPai + '_' + id : id;
Function criarElementoLexML
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
function criarElementoLexML(tipo, conteudo, idPai, idxFilho, unico, nEmenda, rotulos) {
Function criarRotuloLexML
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function criarRotuloLexML(tipo, numero, unico, nEmenda, rotulos) {
Identical blocks of code found in 2 locations. Consider refactoring. Open
this.cntSubitens[dispositivoLexML.tagName] = this.cntSubitens[dispositivoLexML.tagName] ? this.cntSubitens[dispositivoLexML.tagName] + 1 : 1;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 53.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
this.cntSubitens[dispositivoLexML.tagName] = this.cntSubitens[dispositivoLexML.tagName] ? this.cntSubitens[dispositivoLexML.tagName] + 1 : 1;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 53.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76