silentrob/superscript

View on GitHub
src/bot/db/import.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function importData has 149 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const importData = function importData(chatSystem, data, callback) {
  if (!data.version || data.version < MIN_SUPPORTED_SCRIPT_VERSION) {
    return callback(`Error: Your script has version ${data.version} but the minimum supported version is ${MIN_SUPPORTED_SCRIPT_VERSION}.\nPlease either re-parse your file with a supported parser version, or update SuperScript.`);
  }

Severity: Major
Found in src/bot/db/import.js - About 5 hrs to fix

    Function eachTopicItor has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const eachTopicItor = function eachTopicItor(topicName, nextTopic) {
        const topic = data.topics[topicName];
        debug.verbose(`Find or create topic with name '${topicName}'`);
        const topicProperties = {
          name: topic.name,
    Severity: Minor
    Found in src/bot/db/import.js - About 1 hr to fix

      Function importData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      const importData = function importData(chatSystem, data, callback) {
        if (!data.version || data.version < MIN_SUPPORTED_SCRIPT_VERSION) {
          return callback(`Error: Your script has version ${data.version} but the minimum supported version is ${MIN_SUPPORTED_SCRIPT_VERSION}.\nPlease either re-parse your file with a supported parser version, or update SuperScript.`);
        }
      
      
      Severity: Minor
      Found in src/bot/db/import.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status