Sign upLogin

silentrob/superscript

View on GitHub
Star
src/bot/getReply/getPendingTopics.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function findPendingTopicsForUser has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const findPendingTopicsForUser = async function findPendingTopicsForUser(user, message, chatSystem, conversationTimeout) {
  const allTopics = await chatSystem.Topic.find({}).lean().exec();

  const tfidf = new TfIdf();
Severity: Minor
Found in src/bot/getReply/getPendingTopics.js - About 1 hr to fix

    Function findPendingTopicsForUser has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    export const findPendingTopicsForUser = async function findPendingTopicsForUser(user, message, chatSystem, conversationTimeout) {
  const allTopics = await chatSystem.Topic.find({}).lean().exec();

  const tfidf = new TfIdf();
    Severity: Minor
    Found in src/bot/getReply/getPendingTopics.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function findConversationTopics has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const findConversationTopics = async function findConversationTopics(pendingTopics, user, chatSystem, conversationTimeout) {
  if (user.history.length === 0) {
    return pendingTopics;
  }
    Severity: Minor
    Found in src/bot/getReply/getPendingTopics.js - About 1 hr to fix

      Function findConversationTopics has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      const findConversationTopics = async function findConversationTopics(pendingTopics, user, chatSystem, conversationTimeout) {
  if (user.history.length === 0) {
    return pendingTopics;
  }
      Severity: Minor
      Found in src/bot/getReply/getPendingTopics.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

          return pendingTopics;
      Severity: Major
      Found in src/bot/getReply/getPendingTopics.js - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status