Sign upLogin

silentrob/superscript

View on GitHub
Star
src/bot/getReply/index.js

Summary

Maintainability
D
2 days
Test Coverage

Function afterHandle has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const afterHandle = function afterHandle(matches) {
  debug.verbose(`Set of matches: ${matches}`);

  const debugAll = [];
  let props = {};
Severity: Major
Found in src/bot/getReply/index.js - About 2 hrs to fix

    Function topicItorHandle has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

    const topicItorHandle = async function topicItorHandle(topicData, messageObject, options) {
  const system = options.system;

  if (topicData.type === 'TOPIC') {
    const topic = await system.chatSystem.Topic.findById(topicData.id, '_id name filter gambits')
    Severity: Minor
    Found in src/bot/getReply/index.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function matchItorHandle has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const matchItorHandle = async function matchItorHandle(match, message, options) {
  const system = options.system;
  options.message = message;

  debug.verbose('Match itor: ', match.gambit);
    Severity: Minor
    Found in src/bot/getReply/index.js - About 2 hrs to fix

      Function findMatches has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      const findMatches = async function findMatches(pendingTopics, messageObject, options) {
  debug.verbose(`Found pending topics/conversations: ${JSON.stringify(pendingTopics)}`);

  const replies = [];
  let stopSearching = false;
      Severity: Minor
      Found in src/bot/getReply/index.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function topicItorHandle has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const topicItorHandle = async function topicItorHandle(topicData, messageObject, options) {
  const system = options.system;

  if (topicData.type === 'TOPIC') {
    const topic = await system.chatSystem.Topic.findById(topicData.id, '_id name filter gambits')
      Severity: Minor
      Found in src/bot/getReply/index.js - About 1 hr to fix

        Function findMatches has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const findMatches = async function findMatches(pendingTopics, messageObject, options) {
  debug.verbose(`Found pending topics/conversations: ${JSON.stringify(pendingTopics)}`);

  const replies = [];
  let stopSearching = false;
        Severity: Minor
        Found in src/bot/getReply/index.js - About 1 hr to fix

          Function matchItorHandle has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

          const matchItorHandle = async function matchItorHandle(match, message, options) {
  const system = options.system;
  options.message = message;

  debug.verbose('Match itor: ', match.gambit);
          Severity: Minor
          Found in src/bot/getReply/index.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

            return false;
          Severity: Major
          Found in src/bot/getReply/index.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return helpers.findMatchingGambitsForMessage('reply', reply, messageObject, options);
            Severity: Major
            Found in src/bot/getReply/index.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return false;
              Severity: Major
              Found in src/bot/getReply/index.js - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    const topic = await system.chatSystem.Topic.findById(topicData.id, '_id name filter gambits')
      .populate({ path: 'gambits', populate: { path: 'replies' } })
      .lean()
      .exec();
                Severity: Major
                Found in src/bot/getReply/index.js and 1 other location - About 1 hr to fix
                src/bot/getReply/index.js on lines 136..139

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 69.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    const reply = await system.chatSystem.Reply.findById(topicData.id, '_id name filter gambits')
      .populate({ path: 'gambits', populate: { path: 'replies' } })
      .lean()
      .exec();
                Severity: Major
                Found in src/bot/getReply/index.js and 1 other location - About 1 hr to fix
                src/bot/getReply/index.js on lines 103..106

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 69.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status