silverbucket/teste

View on GitHub
lib/tools/WebSocketClient.js

Summary

Maintainability
C
1 day
Test Coverage

Function connect has 115 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    WebSocketClient.prototype.connect = function (onComplete) {
      var client = new WebSocket.client();
      var self = this;

      client.on('connectFailed', function (error) {
Severity: Major
Found in lib/tools/WebSocketClient.js - About 4 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                    for (key in cmd.confirmProps) {
                      self.test.assertAnd(cmd.confirmProps[key], msg[key], 'checking for property: '+key);
                    }
    Severity: Major
    Found in lib/tools/WebSocketClient.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                    } else if ((cmd.expected !== undefined) && ((cmd.receivedConfirm) || (typeof cmd.confirmProps === 'undefined'))) {
                      // either confirmation received already, or not expected, continue with
                      // check
      
                      //console.log('actual response: ', message.utf8Data);
      Severity: Major
      Found in lib/tools/WebSocketClient.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                        if (self.test.result() !== false) {
                          console.log('RECEIVED CONFIRM');
                          cmd.receivedConfirm = true;
                        }
        Severity: Major
        Found in lib/tools/WebSocketClient.js - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              var WebSocketClient = function (cfg) {
                if (typeof cfg.url === 'string') {
                  this.url = cfg.url;
                }
                if (typeof cfg.type === 'string') {
          Severity: Major
          Found in lib/tools/WebSocketClient.js and 1 other location - About 2 hrs to fix
          lib/tools/HttpServer.js on lines 36..43

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 77.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status