silverbucket/teste

View on GitHub
lib/tools/assert.js

Summary

Maintainability
C
1 day
Test Coverage

Function isEqual has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function isEqual(a, b) {
    if (b === undefined) { return false; }
    var p;
    if (Array.isArray(a)) {
      if (!Array.isArray(b)) {
Severity: Major
Found in lib/tools/assert.js - About 2 hrs to fix

    Function assert has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      pub.assert = function (one, two, customMsg) {
        customMsg = customMsg ? (' -- ' + customMsg) : '';
        var args = Array.prototype.slice.call(arguments);
        var self = arguments.callee;
        if (typeof one === 'undefined') {
    Severity: Minor
    Found in lib/tools/assert.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                  if (!msg) {
                    msg = p + ": "+ a[p] + " not in second object";
                  }
      Severity: Major
      Found in lib/tools/assert.js - About 45 mins to fix

        Avoid too many return statements within this function.
        Open

            return false;
        Severity: Major
        Found in lib/tools/assert.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return false;
          Severity: Major
          Found in lib/tools/assert.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return true;
            Severity: Major
            Found in lib/tools/assert.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return false;
              Severity: Major
              Found in lib/tools/assert.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                          return false;
                Severity: Major
                Found in lib/tools/assert.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return true;
                  Severity: Major
                  Found in lib/tools/assert.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return true;
                    Severity: Major
                    Found in lib/tools/assert.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return false;
                      Severity: Major
                      Found in lib/tools/assert.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                  return false;
                        Severity: Major
                        Found in lib/tools/assert.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                    return false;
                          Severity: Major
                          Found in lib/tools/assert.js - About 30 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                  if (!a.hasOwnProperty(p)) {
                                    if (b.hasOwnProperty(p)) {
                                      msg = 'property ['+p+'] does not exist in first object';
                                      return false;
                                    }
                            Severity: Minor
                            Found in lib/tools/assert.js and 1 other location - About 45 mins to fix
                            lib/tools/assert.js on lines 70..75

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 50.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                  if (!b.hasOwnProperty(p)) {
                                    if (a.hasOwnProperty(p)) {
                                      msg  = 'property ['+p+'] does not exist in second object';
                                      return false;
                                    }
                            Severity: Minor
                            Found in lib/tools/assert.js and 1 other location - About 45 mins to fix
                            lib/tools/assert.js on lines 64..69

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 50.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status