sirap-group/connect-sequence

View on GitHub

Showing 4 of 4 total issues

Function appendIf has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function appendIf (filter /*, middlewares */) {
  var errorMsg
  var middlewares = []

  if (arguments.length < 2) {
Severity: Minor
Found in lib/ConnectSequence.js - About 1 hr to fix

    Function run has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    function run () {
      var midSequence = this.middlewares.reverse()
      var initialNext = this.next.bind()
      var req = this.req
      var res = this.res
    Severity: Minor
    Found in lib/ConnectSequence.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getBumpType has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    function getBumpType () {
      return argv.patch
      ? 'patch' : (argv.minor)
      ? 'minor' : (argv.major)
      ? 'major' : (argv.prerelease)
    Severity: Minor
    Found in gulpfile.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function appendIf has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    function appendIf (filter /*, middlewares */) {
      var errorMsg
      var middlewares = []
    
      if (arguments.length < 2) {
    Severity: Minor
    Found in lib/ConnectSequence.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language