Sign upLogin

sjauld/lita-coffee

View on GitHub
Star

Showing 2 of 2 total issues

Class Coffee has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Coffee < Handler
      # TODO: money - probably in a separate handler and maybe it already exists??

      # Dependencies
      require 'json'
Severity: Minor
Found in lib/lita/handlers/coffee.rb - About 2 hrs to fix

    Method buy_coffees has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def buy_coffees(response)
        group = get_group(response.user.name)
        message = response.matches[0][0].strip rescue nil
        response.reply("Thanks for ordering the coffee for #{group}!\n--")
        stats = get_coffee_stats(group)
    Severity: Minor
    Found in lib/lita/handlers/coffee.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language