Sign upLogin

sjoerdk/pimsclient

View on GitHub
Star

Showing 9 of 9 total issues

File swagger_models_v0.py has 735 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# generated by datamodel-codegen:
#   filename:  pims_openapi_def_v0.json
#   timestamp: 2024-04-24T08:07:07+00:00

from __future__ import annotations
Severity: Major
Found in pimsclient/autogen/swagger_models_v0.py - About 1 day to fix

    File server.py has 353 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    """Interaction with a webserver running the PIMS web API. This handles the actual
http traffic on one side, and communicates using parsed objects and exceptions on the
other.

Notes
    Severity: Minor
    Found in pimsclient/server.py - About 4 hrs to fix

      File msal.py has 305 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      """Authentication using the Microsoft Authentication library

https://github.com/AzureAD/microsoft-authentication-library-for-python

Notes
      Severity: Minor
      Found in pimsclient/auth/msal.py - About 3 hrs to fix

        Function check_response has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def check_response(response):
        """Check response from PIMS server and raise appropriate exceptions

        Parameters
        ----------
        Severity: Minor
        Found in pimsclient/server.py - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(
        Severity: Minor
        Found in pimsclient/auth/msal.py - About 45 mins to fix

          Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def __init__(
          Severity: Minor
          Found in pimsclient/swagger.py - About 35 mins to fix

            Function quick_auth_with_cert has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def quick_auth_with_cert(
            Severity: Minor
            Found in pimsclient/auth/msal.py - About 35 mins to fix

              Function quick_obtain_token has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def quick_obtain_token(
              Severity: Minor
              Found in pimsclient/auth/msal.py - About 35 mins to fix

                Function get has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def get(
                Severity: Minor
                Found in pimsclient/server.py - About 35 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language