sjsyrek/maryamyriameliamurphies.js

View on GitHub
source/list/sub.js

Summary

Maintainability
C
1 day
Test Coverage

Function takeWhile has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

export const takeWhile = (p, as) => {
  const takeWhile_ = (p, as) => {
    if (isList(as) === false) { return error.listError(as, takeWhile); }
    if (isEmpty(as)) { return emptyList; }
    const x = head(as);
Severity: Minor
Found in source/list/sub.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function dropWhile has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

export const dropWhile = (p, as) => {
  const dropWhile_ = (p, as) => {
    if (isList(as) === false) { return error.listError(as, dropWhile); }
    if (isEmpty(as)) { return emptyList; }
    const x = head(as);
Severity: Minor
Found in source/list/sub.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function stripPrefix has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

export const stripPrefix = (as, bs) => {
  const stripPrefix_ = (as, bs) => {
    if (isList(as) === false) { return error.listError(as, stripPrefix); }
    if (isList(bs) === false) { return error.listError(bs, stripPrefix); }
    if (isEmpty(as)) { return just(bs); }
Severity: Minor
Found in source/list/sub.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function take has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export const take = (n, as) => {
  const take_ = (n, as) => {
    if (isList(as) === false) { return error.listError(as, take); }
    if (n <= 0) { return emptyList; }
    if (isEmpty(as)) { return emptyList; }
Severity: Minor
Found in source/list/sub.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function drop has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export const drop = (n, as) => {
  const drop_ = (n, as) => {
    if (isList(as) === false) { return error.listError(as, drop); }
    if (n <= 0) { return as; }
    if (isEmpty(as)) { return emptyList; }
Severity: Minor
Found in source/list/sub.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return error.listError(as, dropWhile);
Severity: Major
Found in source/list/sub.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return error.listError(as, takeWhile);
    Severity: Major
    Found in source/list/sub.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return Nothing;
      Severity: Major
      Found in source/list/sub.js - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export const splitAt = (n, xs) => {
          const splitAt_ = (n, xs) =>
            isList(xs) ? tuple(take(n, xs), drop(n, xs)) : error.listError(xs, splitAt);
          return partial(splitAt_, n, xs);
        }
        Severity: Major
        Found in source/list/sub.js and 1 other location - About 2 hrs to fix
        source/list/sub.js on lines 172..176

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 76.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export const span = (p, xs) => {
          const span_ = (p, xs) =>
            isList(xs) ? tuple(takeWhile(p, xs), dropWhile(p, xs)) : error.listError(xs, span);
          return partial(span_, p, xs);
        }
        Severity: Major
        Found in source/list/sub.js and 1 other location - About 2 hrs to fix
        source/list/sub.js on lines 100..104

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 76.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status