skeate/Leaflet.timeline

View on GitHub

Showing 6 of 26 total issues

File TimelineSliderControl.ts has 441 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import L from 'leaflet';

interface TimelineSliderControlOptions extends L.ControlOptions {
  /**
   * Minimum time, in ms, for the playback to take. Will almost certainly
Severity: Minor
Found in src/TimelineSliderControl.ts - About 6 hrs to fix

    TimelineSliderControl has 31 functions (exceeds 20 allowed). Consider refactoring.
    Open

    L.TimelineSliderControl = L.Control.extend({
      initialize(options = {}) {
        const defaultOptions: TimelineSliderControlOptions = {
          duration: 10000,
          enableKeyboardControls: false,
    Severity: Minor
    Found in src/TimelineSliderControl.ts - About 3 hrs to fix

      Function _nearestEventTime has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        _nearestEventTime(findTime, mode = 1) {
          const times = this._getTimes();
          let retNext = false;
          let lastTime = times[0];
          for (let i = 1; i < times.length; i++) {
      Severity: Minor
      Found in src/TimelineSliderControl.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _createDOM has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _createDOM() {
          const classes = [
            'leaflet-control-layers',
            'leaflet-control-layers-expanded',
            'leaflet-timeline-control',
      Severity: Minor
      Found in src/TimelineSliderControl.ts - About 1 hr to fix

        Function _makeSlider has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _makeSlider(container) {
            const slider = L.DomUtil.create(
              'input',
              'time-slider',
              container
        Severity: Minor
        Found in src/TimelineSliderControl.ts - About 1 hr to fix

          Function _recalculate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            _recalculate() {
              const manualStart = typeof this.options.start !== 'undefined';
              const manualEnd = typeof this.options.end !== 'undefined';
              const duration = this.options.duration;
              let min = Infinity;
          Severity: Minor
          Found in src/TimelineSliderControl.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language