skofgar/mercury

View on GitHub

Showing 577 of 821 total issues

Avoid too many return statements within this method.
Open

                return engine.createTopic(topic, partition);

    Avoid too many return statements within this method.
    Open

                    return Collections.singletonList(target);

      Avoid too many return statements within this method.
      Open

              return Collections.emptyList();

        Avoid too many return statements within this method.
        Open

                return false;

          Avoid too many return statements within this method.
          Open

                  return false;

            Method write has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                @Override
                public void write(Object o, @Nullable MediaType contentType, HttpOutputMessage outputMessage) throws HttpMessageNotWritableException, IOException {
                    outputMessage.getHeaders().setContentType(TEXT_CONTENT);
                    // this may be too late to validate because Spring RestController has already got the object
                    SimpleObjectMapper mapper = SimpleMapper.getInstance().getSafeMapper(o.getClass().getTypeName());

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method removeExpiredStreams has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public static void removeExpiredStreams() {
                    PostOffice po = PostOffice.getInstance();
                    Utility util = Utility.getInstance();
                    long now = System.currentTimeMillis();
                    List<String> list = new ArrayList<>(streams.keySet());

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method write has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public void write(Object payload) throws IOException {
                    if (payload == null) {
                        // null payload means EOF
                        close();
                    } else {

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getValidatedRoute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private String getValidatedRoute(String route) throws IOException {
                    if (route == null) {
                        throw new IOException("Missing service routing path");
                    }
                    // guarantee that only valid service name is registered

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method load has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                @Override
                public List<PropertySource<?>> load(String name, Resource resource) {
                    if (!ClassUtils.isPresent("org.yaml.snakeyaml.Yaml", getClass().getClassLoader())) {
                        throw new IllegalStateException(
                                "Attempted to load " + name + " but snakeyaml was not found on the classpath");

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method validArgument has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private boolean validArgument(String arg) {
                    if (arg.startsWith("{") && arg.endsWith("}")) {
                        String v = arg.substring(1, arg.length()-1);
                        if (v.length() == 0) {
                            return false;

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method write has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                @Override
                public void write(Object o, @Nullable MediaType contentType, HttpOutputMessage outputMessage)
                        throws HttpMessageNotWritableException, IOException {
                    outputMessage.getHeaders().setContentType(JSON);
                    // this may be too late to validate because Spring RestController has already got the object

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method setResponseHeaders has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private void setResponseHeaders(EventEnvelope event, HttpHeaders headers) {
                    for (String h: headers.keySet()) {
                        /*
                         * Except "set-cookie" that allows multiples,
                         * all other headers are set as single value.

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cleanUp has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public void cleanUp() {
                    long now = System.currentTimeMillis();
                    log.debug("Cleaning up {}", this.getName());
                    // clean up cache
                    List<String> expired = new ArrayList<>();

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method enforceKeysAsText has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                @SuppressWarnings({"rawtypes", "unchecked"})
                private void enforceKeysAsText(Map raw) {
                    Set keys = new HashSet(raw.keySet());
                    for (Object k: keys) {
                        Object v = raw.get(k);

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public Object get(String key) {
                    TimedItem item = cache.get(key);
                    if (item == null) {
                        return null;
                    } else {

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method exists has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public boolean exists(String... routes) {
                    if (routes == null || routes.length == 0) {
                        return false;
                    }
                    if (routes.length == 1) {

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getFlatList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                @SuppressWarnings("unchecked")
                private void getFlatList(String prefix, List<Object> src, Map<String, Object> target) {
                    int n = 0;
                    for (Object v: src) {
                        String key = prefix+"["+n+"]";

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getException has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public Throwable getException() {
                    if (!exRestored) {
                        if (exceptionBytes != null) {
                            try (ObjectInputStream in = new ObjectInputStream(new ByteArrayInputStream(exceptionBytes))) {
                                exception = (Throwable) in.readObject();

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method handle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                @Override
                public void handle(ServerWebSocket ws) {
                    String uri = ws.path().trim();
                    String path = findPath(uri);
                    if (path == null) {

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language