skratchdot/random-useragent

View on GitHub

Showing 3 of 3 total issues

Consider simplifying this complex logical expression.
Open

      if (
        typeof useragent.useragent === 'string' &&
        useragent.useragent.length > 0
      ) {
        useragents.push({
Severity: Critical
Found in scripts/create-data.js - About 3 hrs to fix

    Function parseUseragents has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const parseUseragents = function (folderName, folderItem) {
      if (Object.prototype.hasOwnProperty.call(folderItem, 'useragent')) {
        folderItem.useragent.forEach(function (useragent) {
          useragent = useragent.$;
          uaParser.setUA(useragent.useragent);
    Severity: Minor
    Found in scripts/create-data.js - About 1 hr to fix

      Function parseUseragents has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      const parseUseragents = function (folderName, folderItem) {
        if (Object.prototype.hasOwnProperty.call(folderItem, 'useragent')) {
          folderItem.useragent.forEach(function (useragent) {
            useragent = useragent.$;
            uaParser.setUA(useragent.useragent);
      Severity: Minor
      Found in scripts/create-data.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language