Sign upLogin

skyzyx/php-strong-types

View on GitHub
Star

Showing 9 of 11 total issues

Function validate has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function validate()
    {
        if ($this->value !== null && !is_array($this->value)) {
            throw new UnexpectedValueException(
                sprintf(self::TYPE_EXCEPTION_MESSAGE, get_called_class(), 'array', gettype($this->value))
Severity: Minor
Found in src/StrongTypes/Collection.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getStrongScalarType has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getStrongScalarType($value)
    {
        if ($value === 'true' || $value === 'false') {
            return new BooleanType($value === 'true');
        } elseif (is_bool($value)) {
Severity: Minor
Found in src/StrongTypes/Util.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function validate()
    {
        if ($this->value !== null && !is_array($this->value)) {
            throw new UnexpectedValueException(
                sprintf(self::TYPE_EXCEPTION_MESSAGE, get_called_class(), 'array', gettype($this->value))
Severity: Minor
Found in src/StrongTypes/Collection.php - About 1 hr to fix

Method validate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function validate()
    {
        // @codeCoverageIgnoreStart
        if (!function_exists('idn_to_ascii') && !class_exists('\idna_convert')) {
            throw new Exception('Unable to convert punycode. Either install the PHP Intl extension, or the mabrahamde/idna-converter Composer package.');
Severity: Minor
Found in src/StrongTypes/StringType/Email.php - About 1 hr to fix

Consider simplifying this complex logical expression.
Open

        if (!(
            filter_var($email, FILTER_VALIDATE_EMAIL) && // RFC 822 (obsolete). Exceptions: no comments, no whitespace
            preg_match('/@.+\./', $email) &&             // Standard email formatting
            !preg_match('/@\[/', $email) &&              // Disallow IPv6 domains
            !preg_match('/".+@/', $email) &&             // Disallow quotes
Severity: Major
Found in src/StrongTypes/StringType/Email.php - About 1 hr to fix

Function validate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function validate()
    {
        // @codeCoverageIgnoreStart
        if (!function_exists('idn_to_ascii') && !class_exists('\idna_convert')) {
            throw new Exception('Unable to convert punycode. Either install the PHP Intl extension, or the mabrahamde/idna-converter Composer package.');
Severity: Minor
Found in src/StrongTypes/StringType/Email.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

            return new StringType((string) $value);
Severity: Major
Found in src/StrongTypes/Util.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

            return new IntegerType($value);
Severity: Major
Found in src/StrongTypes/Util.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

            return new FloatType($value);
Severity: Major
Found in src/StrongTypes/Util.php - About 30 mins to fix
Severity
Category
Status
Source
Language