Sign upLogin

slaviqueue/typeorm-pg-adjacency-list-tree

View on GitHub
Star

Showing 2 of 4 total issues

Function extendTreeRepository has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function extendTreeRepository<Entity extends IBaseTreeEntity>(repository: Repository<Entity>) {
  const repo = repository.extend({
    async findTrees(options?: FindTreeOptions) {
      const roots = await this.findRoots(options)
      const trees = await Promise.all(roots.map((root) => this.findDescendantsTree(root, options)))
Severity: Major
Found in lib/repository/tree-repository.ts - About 3 hrs to fix

    Function assemble has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      public assemble(nodes: Entity[], rootId: number) {
    const idToNode = keyBy(nodes, 'id')

    for (const node of nodes) {
      const nodeAsAny = node as any
    Severity: Minor
    Found in lib/repository/tree-assembler.ts - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language