Sign upLogin

slovensko-digital/navody.digital

View on GitHub
Star
app/models/apps/ep_vote_app/application_form.rb
e04fd052 ... b60c671a

Summary

Maintainability
A
C
+1 day
Test Coverage
A
C
-24%

Class ApplicationForm has 31 methods (exceeds 20 allowed). Consider refactoring.
New

    class ApplicationForm
      VOTE_DATE = Date.parse(ENV.fetch('EP_VOTE_DATE', '2024-06-08'))
      REQUEST_SENDING_DEADLINE = VOTE_DATE - 19.days

      include ActiveModel::Model
Severity: Minor
Found in app/models/apps/ep_vote_app/application_form.rb - About 3 hrs to fix

    File application_form.rb has 318 lines of code (exceeds 250 allowed). Consider refactoring.
    New

    module Apps
  module EpVoteApp
    class ApplicationForm
      VOTE_DATE = Date.parse(ENV.fetch('EP_VOTE_DATE', '2024-06-08'))
      REQUEST_SENDING_DEADLINE = VOTE_DATE - 19.days
    Severity: Minor
    Found in app/models/apps/ep_vote_app/application_form.rb - About 3 hrs to fix

      Method run has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      New

            def run(listener)
        case step
        when 'start'
          start_step(listener)
        when 'citizenship'
      Severity: Minor
      Found in app/models/apps/ep_vote_app/application_form.rb - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        New

              def citizenship_step(listener)
        if go_back?
          listener.render :start
        elsif valid?(:citizenship)
          case citizenship
        Severity: Minor
        Found in app/models/apps/ep_vote_app/application_form.rb and 1 other location - About 35 mins to fix
        app/models/apps/ep_vote_app/application_form.rb on lines 254..268

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        New

              def delivery_step(listener)
        if go_back?
          listener.render :place
        elsif valid?(:delivery)
          case delivery
        Severity: Minor
        Found in app/models/apps/ep_vote_app/application_form.rb and 1 other location - About 35 mins to fix
        app/models/apps/ep_vote_app/application_form.rb on lines 174..188

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        New

              def place_step(listener)
        if go_back?
          listener.render :sk_citizen_residency
        elsif valid?(:place)
          case place
        Severity: Minor
        Found in app/models/apps/ep_vote_app/application_form.rb and 1 other location - About 25 mins to fix
        app/models/apps/ep_vote_app/application_form.rb on lines 208..220

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 31.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        New

              def eu_citizen_residency_step(listener)
        if go_back?
          listener.render :citizenship
        elsif valid?(:eu_citizen_residency)
          case eu_citizen_residency
        Severity: Minor
        Found in app/models/apps/ep_vote_app/application_form.rb and 1 other location - About 25 mins to fix
        app/models/apps/ep_vote_app/application_form.rb on lines 239..251

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 31.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Fixed

        Severity: Minor
        Found in app/models/apps/ep_vote_app/application_form.rb and 1 other location - About 20 mins to fix
        app/models/apps/ep_vote_app/application_form.rb on lines 130..141

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 27.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Fixed

        Severity: Minor
        Found in app/models/apps/ep_vote_app/application_form.rb and 1 other location - About 20 mins to fix
        app/models/apps/ep_vote_app/application_form.rb on lines 144..155

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 27.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status