Sign upLogin

smileart/mac-say

View on GitHub
Star

Showing 4 of 4 total issues

File voices_attributes.rb has 626 lines of code (exceeds 250 allowed). Consider refactoring.
Open

ADDITIONAL_VOICE_ATTRIBUTES = {
    _unknown_voice: {
      gender: nil,
      joke: nil,
      quality: nil,
Severity: Major
Found in lib/mac/say/voices_attributes.rb - About 1 day to fix

    Method voice has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def voice(attribute = nil, value = nil, &block)
      return unless (attribute && !value.nil?) || block_given?
      raise UnknownVoiceAttribute, "Voice has no '#{attribute}' attribute" if attribute && !VOICE_ATTRIBUTES.include?(attribute)

      if block_given?
    Severity: Minor
    Found in lib/mac/say.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method say has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def say(string: nil, file: nil, voice: nil, rate: nil)
      if voice
        raise VoiceNotFound, "Voice '#{voice}' isn't a valid voice" unless valid_voice?(voice)
        @config[:voice] = voice
      end
    Severity: Minor
    Found in lib/mac/say.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method generate_command has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def generate_command
      say_path = @config[:say_path]
      file     = @config[:file]

      raise CommandNotFound, "Command `say` couldn't be found by '#{@config[:say_path]}' path" unless valid_command_path? say_path
    Severity: Minor
    Found in lib/mac/say.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language