smortex/tls-checker

View on GitHub

Showing 3 of 3 total issues

Method certificate_checkers_for has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def certificate_checkers_for(specification) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
      hostname, port, starttls = specification.split(':', 3)

      port = port.to_i if port
      starttls = starttls.to_sym if starttls
Severity: Minor
Found in lib/tls_checker/certificate_checker_factory.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method certificate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def certificate
      return @certificate unless @certificate.nil?

      if tls_socket.peer_cert
        @certificate = OpenSSL::X509::Certificate.new(tls_socket.peer_cert)
Severity: Minor
Found in lib/tls_checker/certificate_checker.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method tlsa_checkers_for has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def tlsa_checkers_for(certificate_checker)
      res = []
      return res unless certificate_checker.certificate

      each_tlsa_end_entity_record(certificate_checker) do |record|
Severity: Minor
Found in lib/tls_checker/tlsa_checker_factory.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language