Sign upLogin

so5/ssh-client-wrapper

View on GitHub
Star

Showing 27 of 33 total issues

Avoid too many return statements within this function.
Open

    return send(this.hostInfo, src, dst, opt, timeout);
Severity: Major
Found in lib/index.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          return logAndReject("opt must be array of string");
    Severity: Major
    Found in lib/index.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return recv(this.hostInfo, src, dst, opt, timeout);
      Severity: Major
      Found in lib/index.js - About 30 mins to fix

        Function send has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          async send (src, dst, opt = [], timeout = 0) {
    debug("send called", src, dst, opt);

    if (!isArrayOfString(src)) {
      return logAndReject("src must be array of string");
        Severity: Minor
        Found in lib/index.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getControlPersistDir has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function getControlPersistDir (hostInfo) {
  for (const candidate of [hostInfo.ControlPersistDir, process.env.SSH_CONTROL_PERSIST_DIR]) {
    if (typeof candidate === "string") {
      const stat = fs.statSync(candidate, { throwIfNoEntry: false });
      if (stat.isDirectory()) {
        Severity: Minor
        Found in lib/util.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          constructor (hostInfo) {
    debug("constructor called for", hostInfo.host);
    debugVerbose("hostInfo=", hostInfo);
    this.hostInfo = { ...hostInfo };
    sanityCheck(this.hostInfo);
        Severity: Minor
        Found in lib/index.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function existsMaster has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        async function existsMaster (hostInfo, argTimeout) {
  debugVerbose("existsMaster called");
  const args = getSshOption(hostInfo);
  args.push("-Ocheck");
        Severity: Minor
        Found in lib/sshExec.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language