Sign upLogin

sockethub/sockethub

View on GitHub
Star
packages/platform-xmpp/src/incoming-handlers.js

Summary

Maintainability
A
0 mins
Test Coverage

Function stanza has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Invalid

    stanza(stanza) {
        // console.log("incoming stanza ", stanza);
        if (stanza.attrs.type === "error") {
            this.notifyError(stanza);
        } else if (stanza.is("message")) {
Severity: Minor
Found in packages/platform-xmpp/src/incoming-handlers.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File incoming-handlers.js has 292 lines of code (exceeds 250 allowed). Consider refactoring.
Invalid

function getMessageBody(stanza) {
    for (let elem of stanza.children) {
        if (elem.name === "body") {
            return elem.children.join(" ");
        }
Severity: Minor
Found in packages/platform-xmpp/src/incoming-handlers.js - About 3 hrs to fix

    Function stanza has 68 lines of code (exceeds 25 allowed). Consider refactoring.
    Invalid

        stanza(stanza) {
        // console.log("incoming stanza ", stanza);
        if (stanza.attrs.type === "error") {
            this.notifyError(stanza);
        } else if (stanza.is("message")) {
    Severity: Major
    Found in packages/platform-xmpp/src/incoming-handlers.js - About 2 hrs to fix

      Function notifyChatMessage has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Invalid

          notifyChatMessage(stanza) {
        const message = getMessageBody(stanza);
        if (!message) {
            return;
        }
      Severity: Minor
      Found in packages/platform-xmpp/src/incoming-handlers.js - About 1 hr to fix

        Function notifyRoomAttendance has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Invalid

            notifyRoomAttendance(stanza) {
        const query = stanza.getChild("query");
        if (query) {
            let members = [];
            const entries = query.getChildren("item");
        Severity: Minor
        Found in packages/platform-xmpp/src/incoming-handlers.js - About 1 hr to fix

          Function notifyError has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Invalid

              notifyError(stanza) {
        const error = stanza.getChild("error");
        let message = stanza.toString();
        let type = "message";
        if (stanza.is("presence")) {
          Severity: Minor
          Found in packages/platform-xmpp/src/incoming-handlers.js - About 1 hr to fix

            Function notifyChatMessage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Wontfix

                notifyChatMessage(stanza) {
        const message = getMessageBody(stanza);
        if (!message) {
            return;
        }
            Severity: Minor
            Found in packages/platform-xmpp/src/incoming-handlers.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function notifyRoomAttendance has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Wontfix

                notifyRoomAttendance(stanza) {
        const query = stanza.getChild("query");
        if (query) {
            let members = [];
            const entries = query.getChildren("item");
            Severity: Minor
            Found in packages/platform-xmpp/src/incoming-handlers.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Wontfix

            function getMessageReplaceId(stanza) {
    try {
        const replaceEl = stanza.children.find((c) => c.name === "replace");
        return replaceEl.attrs.id;
    } catch (e) {
            Severity: Major
            Found in packages/platform-xmpp/src/incoming-handlers.js and 2 other locations - About 1 hr to fix
            packages/platform-xmpp/src/incoming-handlers.js on lines 9..17
            packages/platform-xmpp/src/incoming-handlers.js on lines 28..36

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 70.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Wontfix

            function getMessageTimestamp(stanza) {
    try {
        const delay = stanza.children.find((c) => c.name === "delay");
        return delay.attrs.stamp;
    } catch (e) {
            Severity: Major
            Found in packages/platform-xmpp/src/incoming-handlers.js and 2 other locations - About 1 hr to fix
            packages/platform-xmpp/src/incoming-handlers.js on lines 28..36
            packages/platform-xmpp/src/incoming-handlers.js on lines 38..46

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 70.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Wontfix

            function getMessageStanzaId(stanza) {
    try {
        const stanzaId = stanza.children.find((c) => c.name === "stanza-id");
        return stanzaId.attrs.id;
    } catch (e) {
            Severity: Major
            Found in packages/platform-xmpp/src/incoming-handlers.js and 2 other locations - About 1 hr to fix
            packages/platform-xmpp/src/incoming-handlers.js on lines 9..17
            packages/platform-xmpp/src/incoming-handlers.js on lines 38..46

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 70.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status