sodabrew/puppet-dashboard

View on GitHub
app/assets/javascripts/jquery.tokeninput.js

Summary

Maintainability
F
3 days
Test Coverage

Function TokenList has 388 lines of code (exceeds 25 allowed). Consider refactoring.
Open

$.TokenList = function (input, settings) {
    //
    // Variables
    //

Severity: Major
Found in app/assets/javascripts/jquery.tokeninput.js - About 1 day to fix

    File jquery.tokeninput.js has 446 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
     * jQuery Plugin: Tokenizing Autocomplete Text Entry
     * Version 1.1
     *
     * Copyright (c) 2009 James Smith (http://loopj.com)
    Severity: Minor
    Found in app/assets/javascripts/jquery.tokeninput.js - About 6 hrs to fix

      Function populate_dropdown has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function populate_dropdown (query, results) {
              if(results.length) {
                  dropdown.empty();
                  var dropdown_ul = $("<ul>")
                      .appendTo(dropdown)
      Severity: Minor
      Found in app/assets/javascripts/jquery.tokeninput.js - About 1 hr to fix

        Consider simplifying this complex logical expression.
        Open

                if((keycode >= 48 && keycode <= 90) ||      // 0-1a-z
                   (keycode >= 96 && keycode <= 111) ||     // numpad 0-9 + - / * .
                   (keycode >= 186 && keycode <= 192) ||    // ; = , - . / ^
                   (keycode >= 219 && keycode <= 222)       // ( \ ) '
                  ) {
        Severity: Critical
        Found in app/assets/javascripts/jquery.tokeninput.js - About 1 hr to fix

          Function tokenInput has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          $.fn.tokenInput = function (url, options) {
              var settings = $.extend({
                  url: url,
                  hintText: "Type in a search term",
                  noResultsText: "No results",
          Severity: Minor
          Found in app/assets/javascripts/jquery.tokeninput.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                $("<span>x</span>")
                                    .addClass(settings.classes.tokenDelete)
                                    .appendTo(this_token)
                                    .click(function () {
                                        delete_token($(this).parent());
            Severity: Major
            Found in app/assets/javascripts/jquery.tokeninput.js and 1 other location - About 1 hr to fix
            app/assets/javascripts/jquery.tokeninput.js on lines 327..333

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  $("<span>x</span>")
                      .addClass(settings.classes.tokenDelete)
                      .appendTo(this_token)
                      .click(function () {
                          delete_token($(this).parent());
            Severity: Major
            Found in app/assets/javascripts/jquery.tokeninput.js and 1 other location - About 1 hr to fix
            app/assets/javascripts/jquery.tokeninput.js on lines 268..274

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                var token_list = $("<ul />")
                    .addClass(settings.classes.tokenList)
                    .insertAfter(hidden_input)
                    .click(function (event) {
                        var li = get_element_from_event(event, "li");
            Severity: Minor
            Found in app/assets/javascripts/jquery.tokeninput.js and 1 other location - About 55 mins to fix
            app/assets/javascripts/jquery.tokeninput.js on lines 201..228

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if(settings.method == "POST") {
                            $.post(settings.url + queryStringDelimiter + settings.queryParam + "=" + query, {}, callback, settings.contentType);
                        } else {
            Severity: Minor
            Found in app/assets/javascripts/jquery.tokeninput.js and 1 other location - About 35 mins to fix
            app/assets/javascripts/jquery.tokeninput.js on lines 564..566

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        } else {
                            $.get(settings.url + queryStringDelimiter + settings.queryParam + "=" + query, {}, callback, settings.contentType);
                        }
            Severity: Minor
            Found in app/assets/javascripts/jquery.tokeninput.js and 1 other location - About 35 mins to fix
            app/assets/javascripts/jquery.tokeninput.js on lines 562..564

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status