sombreroEnPuntas/car-gallery

View on GitHub
pages/index.js

Summary

Maintainability
A
1 hr
Test Coverage

Function render has 53 lines of code (exceeds 50 allowed). Consider refactoring.
Open

  render() {
    const { error, isLoading, retries, step } = this.state
    const fieldHelper = makeFieldHelper(this.state, this.handleUpdate)

    const carsFound = getCarsFiltered(this.state)
Severity: Major
Found in pages/index.js - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Invalid

          else if (
            !!make.value &&
            make.valid &&
            !!model.value &&
            model.valid &&
    Severity: Major
    Found in pages/index.js - About 40 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Invalid

                <FormSection active={step === 1} id="part-1">
                  <p>{'Available makes:'}</p>
                  <DropdownField {...fieldHelper('make')} />
      
                  <p>{'Available models:'}</p>
      Severity: Major
      Found in pages/index.js and 2 other locations - About 2 hrs to fix
      pages/index.js on lines 233..239
      pages/index.js on lines 240..246

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 88.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Invalid

                <FormSection active={step === 2} id="part-2">
                  <p>{'Available body types:'}</p>
                  <SelectField {...fieldHelper('bodyType')} />
      
                  <p>{'Available fuel types:'}</p>
      Severity: Major
      Found in pages/index.js and 2 other locations - About 2 hrs to fix
      pages/index.js on lines 226..232
      pages/index.js on lines 240..246

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 88.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Invalid

                <FormSection active={step === 3} id="part-3">
                  <p>{'Available engine capacities:'}</p>
                  <SelectField {...fieldHelper('engineCapacity')} />
      
                  <p>{'Available engine power:'}</p>
      Severity: Major
      Found in pages/index.js and 2 other locations - About 2 hrs to fix
      pages/index.js on lines 226..232
      pages/index.js on lines 233..239

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 88.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

                  {step !== 1 ? (
                    <a data-test-id="back" onClick={this.handleStepClick('back')}>
                      {'< Back'}
                    </a>
                  ) : (
      Severity: Minor
      Found in pages/index.js and 1 other location - About 55 mins to fix
      pages/index.js on lines 258..264

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

                  {step !== 3 ? (
                    <a data-test-id="next" onClick={this.handleStepClick('next')}>
                      {'Next >'}
                    </a>
                  ) : (
      Severity: Minor
      Found in pages/index.js and 1 other location - About 55 mins to fix
      pages/index.js on lines 251..257

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status